Support Google Publisher Tags

subscribe

Marking #1322754: Support Google Publisher Tags as duplicate.

Glad to see that we have active users ;-) Sad news is that I haven't used this module for a while (we outsourced to a third party, who does not use Google Publisher Tags but their own servers). So I could just eventually test or commit patch.

+1

+1

Is there any progress on this, as I have a client who is pretty keen to get this going.

I have built an implementation of the GPT in my own fork. see http://drupal.org/sandbox/gordon/1358952

it is only for 6.x ATM, and I am not sure if I should merge this back in, as the way I implemented it, I think that I could add plugins for any type of ad provider.

Let me know if there are any issues. I am currently in the process of testing this with one of my clients, and I am looing to add in the GPT Sync soon.

No problem on ctools dependency. I like the idea of different providers GAM, GPT-async and GPT-sync. Lazy loading is still very useful in sync-implementations.

If one or two developers can review and test the patch, I'm willing to create a 3.x branch and commit it.

I am happy to put it into Google AdManage, but because it could load anything I thought about renaming it to just ad manager and then going on from there.

There is still a lot of cleaning up to do on it, but this is now working, and for my client they are testing with the idea of going live with it.

Gordon.

Any update on this?

subscribing

I'd love to try this out, however, I'm having trouble getting a hold of your code. Would love to help out if I can.
EDIT: got the code, new to git, sorry. should be testing shortly.

Working great for me so far in testing. Re-working other custom modules to work with it in hopes of going live. Thanks!

I have been running this in production for a couple of months. the great thing is that it has taken one sites overall site load time from 35-45 seconds to 15-20 seconds

I hope this is the right place to discuss this...(?)

@gordon, thanks again for your efforts!

I'm having a bit of trouble with adding attributes (node, vocabs, and custom variables) and think I may have found a typo at line 407 of google_admanager.module (sandbox/gordon/1358952)

google_admanager_get_variables($variable. $value);

renders as (node type is 'gallery')

.setTargeting('node-typegallery', '');

changing the "." to a "," fixes node types at least.

google_admanager_get_variables($variable, $value);

now renders correctly as

.setTargeting('node-type', 'gallery');

I'll keep troubleshooting... if I can solve the other issues I'll submit a patch.

Next tasks:
Custom variables are not displaying the value, rendering as: .setTargeting('node', ''). Looks like there is an issue with Token-replace... still need to make sure this isn't my local dev or code causing this issue. Update: only GLOBAL tokens work for me. Looking into this, not sure if there is a solution.

Vocabs are displaying like this .setTargeting('v-', '') (works as designed)

Thanks for pointing this out. I have fixed this on my fork http://drupal.org/sandbox/gordon/1358952

There is also an issue queue over there as well which you can log issues and I can properly attribute you when this is done.

Thanks.

Gordon, even it needs a lot of clean up, I'm willing to merge your branch back to 6.x-2.x branch if you could maintain it. I think toemaz will be ok with that.

Or will I just create 6.x-3.x branch with GPT support? Then there will be more work unless we deprecate 2.x branches.

Any update on this?

I'm working on this on the 6.x-3.x branch based on gordon's work.

@gordon: could you explain this commit http://drupalcode.org/sandbox/gordon/1358952.git/commitdiff/dc84ef7? I think we have two undefined variables $conf and $plugin.

I went ahead and created 6.x-3.x branch. All commits from gordon's branch have been merged. I only did a quick check. Please wait for a few more commits.

I haven't checked that module. But why duplicate instead of working on the 7.x branch?

I said in 2011 (#7) that I was willing to open 3.x branch if someone was interested in working with it. However there was no one (it looks like gordon did not want to maintain that branch ;-) so he keeps it in a sandbox project).

Well, what's done is done. Now I'm again using this module, so I've made the 3.x branch. If you are interested in maintaining the (upcoming) 7.x-3.x branch, I think we can ask toemaz (the project owner) to add you as co-maintainer.

The module name is really not that important.

Guys, any hints on stability of 3.x branch ?
I really want to switch to async mode but don't want to break anything on a live site :)
Is it production-ready ?

@crea I'm using it on a live site. But test it to see if it breaks on yours.

I think the D6 branch is ok. Move back to D7 for a forward port.

Ok, I've switched to 3.x
Async loading is too sweet to skip it.

Just got 6.x-3.x working on our production sites and it's mega-sweet! Thanks for that!

I'm looking long-term into upgrading to 7 ... is there interest in a 7.x-3.x branch or should we move to the gpt project for that core version?

Thanks again!

I can't tell. I haven't look at the gpt project. But I'm willing to review/commit if someone submit a patch to port 3.x branch to D7.

Note: you should only set the "assigned" field to your name if you plan on working on it.

Yeah, I committed it in the 6.x branch but forgot to unassign. BTW I updated the project page a few days ago saying that you should check the dfp module, or use the 7.x branch of google_dfp module.

I suggest instead adding a node on the project page suggesting people use the GPT module if they want async ad loading.