When using signwriter with a title with a single quote in it, like Who's online, the function theme_signwriter_text_convert generates invalid markup. I get this error from the W3 validator:

Error Line 186 column 136: an attribute value literal can occur in an attribute specification list only after a VI delimiter.
...f7601a5e55b562.gif' alt='Who's online' /<

I propose to change the single quotes for attributes in that theme function to be double quotes (they are more 'mainstream') and to replace quotes in the attribute values with entities.

CommentFileSizeAuthor
#5 signwriter.module_0.patch26.68 KBbobwaycott
#4 signwriter.module.patch26.68 KBbobwaycott

Comments

agileware’s picture

agileware commented
Status: Active » Fixed

I've added a call to htmlspecialchars for the image alt text to fix this in cvs.

decafdennis’s picture

decafdennis commented
Status: Fixed » Active

Please also change the single quotes to double quotes for consistency with the rest of Drupal (and the rest of the world for that matter).

Thanks!

wrunt’s picture

wrunt commented
Status: Active » Fixed

I don't really think that's necessary. Both types of quotes are allowed by the XML spec.

bobwaycott’s picture

bobwaycott commented
StatusFileSize
new signwriter.module.patch26.68 KB

I am attaching a patched signwriter.module file that fixes this issue for XHTML Strict validation. I have added in escaped quotes at the necessary line, which causes the XHTML validation to pass completely. No rendering issues occur.

If both types of quotes were allowed, this would pass XHTML Strict validation. I only work in XHTML Strict, so it is necessary to have the double quotes.

Thanks for a great module.

bobwaycott’s picture

bobwaycott commented
StatusFileSize
new signwriter.module_0.patch26.68 KB

Sorry, after viewing the generated source, the alt text shows up as

alt=" ' ' "

I have removed the single quote in favor of the standards-compliant double in this updated patch.

Generated source now shows:

alt=" "

Passes XHTML 1.0 Strict validation.

bobwaycott’s picture

bobwaycott commented

The only issue I have is this module isn't generating the contents of $text in the <img alt=" " /> source either way. Having proper alt text is necessary for accessibility.

Any thoughts?

decafdennis’s picture

decafdennis commented
Status: Fixed » Active

@bobwaycott: If you want the module maintainer to look at this issue, you should change this issue's status back to active (I now did). Also try to provide patches instead of complete files, as described at Patches. If you post a patch, set the issue status to patch (code needs review).

I'm all in for changing all the single quotes in the generated (x)html to double quotes. Why be different?

agileware’s picture

agileware commented
Status: Active » Fixed

This has been fixed in the development version of the module and will be available in the next release.

agileware’s picture

agileware commented
Status: Fixed » Closed (won't fix)

I've changed it back out of principle.

Here is the XML specification for XHTML Strict.
[10]   AttValue   ::=   '"' ([^<&"] | Reference)* '"' |  "'" ([^<&'] | Reference)* "'"

If you can read regular expressions, the specification clearly caters for both.