Download & Extend
Libraries API » Issues

Document libraries_get_version() pattern matching more explicitly.

Posted by tstoeckler on October 27, 2011 at 1:43pm
Project:Libraries API
Version:7.x-2.x-dev
Component:Documentation
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Coming from #1318946: Notice: Undefined offset: 1 in libraries_get_version().
Apparently the authors of Facebook Connect were under the impression libraries_get_version would match the entire pattern, and not the first subpattern. They can't really be blamed, as that is not really explicitly stated anywhere.

Login or register to post comments

Comments

#1

Posted by tstoeckler on November 7, 2011 at 9:04pm
Status:active» needs review

Here we go. I'll let this sit a few days, in case someone wants to review, otherwise I'll commit this as is.

AttachmentSizeStatusTest resultOperations
1323530-libraries-version-pattern-docs.patch1.8 KBIdlePASSED: [[SimpleTest]]: [MySQL] 128 pass(es).View details

#2

Posted by sun on November 8, 2011 at 11:34am
Status:needs review» reviewed & tested by the community

#3

Posted by 4haron on November 9, 2011 at 3:01pm

Hi,

Not very familiar with patches..

Any hint as to where to paste the patch text into?

Thanks!

#4

Posted by 4haron on November 9, 2011 at 11:42pm

#1: 1323530-libraries-version-pattern-docs.patch queued for re-testing.

#5

Posted by 4haron on November 9, 2011 at 11:44pm

oops. sorry. didn't mean to submit for a re test..

#6

Posted by tstoeckler on November 12, 2011 at 2:04am
Status:reviewed & tested by the community» fixed

Thanks for the heads-up. :)
Comitted to 7.x-2.x
http://drupal.org/commitlog/commit/10030/c5515bd18487b64744d4df7b3161985...

@4haron: See http://drupal.org/patch/apply for help

#7

Posted by System Message on November 26, 2011 at 2:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.