It would be nice to have the cass class active-trail added to the element if a <nolink> item actually is in the active trail.
This would make it easier to create the css in some cases.

I've added two patches because the file has quite a lot trailing spaces - which should be removed to comply with the coding standard.
The ignored-spaces patch makes the review easier, but the normal patch should be applied.

CommentFileSizeAuthor
special_menu_items-set-css-class-active-trail-if-applicable.patch6.85 KBdas-peter
special_menu_items-set-css-class-active-trail-if-applicable-ignored-spaces.patch864 bytesdas-peter

Comments

gagarine’s picture

gagarine commented
Status: Needs review » Patch (to be ported)

Yeah good idea. thanks for the patch.

das-peter’s picture

das-peter commented

May I ask if you could commit the patch to the D7 branch?
Would be nice to have this at least in the "Dev" version ;)
Many thanks in advance.

webflo’s picture

webflo commented
Assigned: Unassigned » webflo
gagarine’s picture

gagarine commented
Status: Patch (to be ported) » Fixed

committed in 7.x-dev
http://drupalcode.org/project/special_menu_items.git/commit/06da116
http://drupalcode.org/project/special_menu_items.git/commit/a7b8af1

Sorry it was late and I totally fail to give you the credit :(

das-peter’s picture

das-peter commented

@gagarine: Thanks for committing this - and never mind because of the credit, I'm here to get things done and not to collect credits... :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

petergus’s picture

petergus commented

Im looking to use this functionality but i notice the code has changed heavily since then... how can i implement this in the latest dev (version 2.0)?

EDIT: it only seems to be working for one language... very strange!
i have entity translation and my translated language is working, but not english.