From #825692-28: Pager or navigation for the carousel

I also used JSLint to find some other minor errors, such as missing semicolons (which would prevent compression from working) and fixed some minor whitespace inconsistencies. The attached patch "jslint-validation.patch" includes only these changes.

CommentFileSizeAuthor
#2 jcarousel_semicolon.patch1.37 KBquicksketch
#1 jslint-validation.patch1.21 KBquicksketch
for-each-scope.patch1001 bytesquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review
StatusFileSize
new jslint-validation.patch1.21 KB

Sorry this was the patch I meant to include from that same comment.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new jcarousel_semicolon.patch1.37 KB

The patch didn't apply cleanly after all the other recent changes. Here's a reroll that adds the missing semicolons and makes a correction to the "settings" variable, which doesn't need to be locally scoped because it's already a local argument. Committed to both 2.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.