Upgrading from 6.x-1.3 to 6.x-2.1

I just upgraded a dozen modules (including core 6.x), using the Hail Mary approach, and only Nice Menus broke the site. *frustrated*

I deleted the entire Nice Menus (6.x-1) folder before extracting the 6.x-2 version, ran update.php, and cleared caches...several times.

This one's a really simple D6.22 site. I don't have any theme overrides, nor custom templates, or anything else that would be calling those functions. Had to rollback to 6.x-1. But, would like to upgrade to a supported version.

All of the the themeable functions with the string "nice_menu" in them have been changed to "nice_menus" with an "s." The parameters passed into those themeable functions have changed also. That's why any calls to theme('nice_menu_primary_links') will return an error.

The hook_theme function in nice_menus.module still defines the old function names without the "s", with a comment saying the old functions have been "deprecated" and "will be removed in 7.x." However, the actual functions without the "s" are not defined anymore -- just the old function names. This means that any code which tries to call the old function names will produce an error message.

We ran into this same issue some time back and yeah trying to remember NOT to update Nice Menus sucks due to the broken upgrade path. If someone could document the steps to do this correctly, that would be keen.

@DigitalFrontier: I think you just need to find any places in your code that call theme('nice_menu_primary_links") and change them to theme('nice_menus_primary_links") with an "s" in "nice_menus". Also, make sure that the parameters you pass in conform to the current function profile.

@Sheldon Well, that's just it. I don't have any custom code in this instance pertaining to the use of Nice Menus. I'm using the Nice Menus block for the Primary Links.
D6.25, Nice Menus 6.x-1.3, custom Zen 6.x-1.2 subtheme (though nothing really special going on there). Our experience with Nice Menus breaking was some months ago. And we've avoided it since. Could it be something left in the variables table or could just be another issue/conflict? I should take a closer look at it again and report back.

@DigitalFrontier: Is there anything that overrides nice menu theming in the template.php file of yoru Zen subtheme?

No, there is nothing like that going on. I went back and at least looked for that after reading your fix. End of this month, I'll attempt an upgrade again and pay better attention to what's going on and report back. Thanks.

@DigitalFrontier: If you get really hung up and can't figure out the fix, let me know. To investigate further, though, I'd probably need SSH and/or FTP access to your codebase.

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks