REST server cannot properly handle requests with Content-Type=multipart/form-data.

I think the bot is fucked up?

#1: REST-server-multipart-handling-1324818-1.patch queued for re-testing.

#1: REST-server-multipart-handling-1324818-1.patch queued for re-testing.

I ran tests locally and it looks there is no fails. Bot doesn't work properly.

Meanwhile regarding the patch, it introduces trailing spaces and some styling corrections should be done.

+        // see http://php.net/manual/en/wrappers.php.php
+        if($mime == 'multipart/form-data') {
+          $data = call_user_func($parser);

should have space after "if"

+++ b/servers/rest_server/includes/RESTServer.incundefined
@@ -271,18 +271,23 @@ class RESTServer {
+          $data = call_user_func($parser);
+        } else {
+          // Read the raw input stream

should be

{
else {

+++ b/servers/rest_server/includes/RESTServer.incundefined
@@ -470,6 +475,11 @@ class RESTServer {
+  ¶
+  public static function parseMultipart() {
+    return $_POST;
+  }

trailing spaces introduced

What is the use case when we receive enctype="multipart/form-data" and have both uploaded file and POST data? I would love to have a test for this case. I have only form submit on my mind.

@Taran2l Could you please reroll the patch with style corrections and let me know what do you think about use case?

Thanks!

This patch looks good to me.

Taran, you can do all sorts of alters on the resources or even pre-processing every call. But if you need to explicitly handle files a different way, you can always alter the resource definition via hook_services_resources_alter

We need a 6.x of this when its committed.

Committed thanks

Sorry but it seems that you forgot to commit the following somehow (in the 6.x branch at least):

public static function parseMultipart() {
  return $_POST;
}

Everything else from the patch is nicely in the latest stable release and the -dev.. but this sadly ain't.. which breaks everything obviously :)

Cheers

Fixed. Thanks

fixed typo.