I think displaying checkout validation errors inline with the pane should be reconsidered. If there's a validation error with a pane that's "below the fold," after submitting the user will be right back at the same screen, unexpectedly, with no indication of why. Scrolling down reveals the error, but it's still a source of unnecessary confusion.

Perhaps an error message at the top of the form indicating something like "Please correct the errors below" is in order?

This might be a dupe, or be rolled into, #1243500: Preserve normal Drupal messages on checkout pages

Comments

rszrama’s picture

rszrama commented
Category: bug » feature

I like the idea. Let's keep it separate from that other issue as a feature request. There may be a challenge as it pertains to AJAX forms - i.e. we only need a message at the top when the full form is being submitted and doesn't pass validation, not when an AJAX submission is made that include invalid field data.

rszrama’s picture

rszrama commented
Title: Checkout messages are not a good user experience when ONLY attached to their pane » Show a message at the top of the checkout form when there are errors below the fold
rszrama’s picture

rszrama commented
Status: Active » Fixed

Ran this by Damien and he said just to make sure it was themeable. While I was working on that, I realized it would help to make the help text themeable, too. What we have now are two theme templates, one for the help text and one for a checkout errors message div that by default will appear right beneath the help text on a checkout form that has errors in it. The checkout errors message notification will not show up for errors on the first visible checkout pane, as that pane's error messages would already be visible at the top of the page.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/11e52ae

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.