Port Admin Menu to 6.x

I had a quick look at the new menu system. First of all - bad news: The global variable $_menu does not exist anymore. It seems that there's no function yet designed to retrieve (and alter) the complete, expanded menu tree.

This is shocking… Because until now the main advantage of admin_menu was that it doesn't alter the menu in any way. We might need to completely rewrite the module to extract administrative menu items to a new menu at installation time.

I'll greatly appreciate any input and/or patches from anyone having deeper insights into the new menu system.

After talking to chx on IRC the new menu system will have a hook_menu_alter() that will allow the operations needed for admin_menu. However, the hook still is under heavy development, so we'll have to wait until there is a solid ground on which we can base this update.

OK, thanks for following this :-)

Since Drupal 6 beta is about to be released, Admin Menu should be available ASAP.

Currently, I'm very busy with several projects, so if anyone has successfully or unsuccessfully attempted to port Admin Menu for 6.x I would be glad to test, review, fix or commit any patch. :)

First try. Includes plenty of debug code.

Critical issue: menu_links does not contain any local tasks. In this patch, I've tried to retrieve them manually through a crude database query. Even if this could work out somehow, we'd still have an unresolved issue regarding adding and altering menu items.

A completely different approach could be:

1. Invoke menu_router_build() to get a "copy" of the current menu structure (cached).
2. Perform alterations on this structure.
3. Implement a fork of _menu_navigation_links_rebuild().
4. Implement a magic function which turns this structure into a menu tree, like menu_tree_output() expects it.

Attachment	Size
admin_menu.patch	20.81 KB

subscribing and so sad to have started a multi install in d6 without checking on this module.. so sad..

I just loaded up a brand spanking new multi-site dev environment based on D6. I'm no coder, but I 'm a big fan of this module and would love to contribute testing. Should I start with the patch posted here, which is probabably out-of-date already, or will a 6.x-dev be available sometime soon? FYI I"m windows based and have access to FF2, IE6, and IE7 for testing purposes.

@WorldFallz: Patch in #5 should still apply, but the outlined problems remain.

subscribing

subscribing

New patch with improvements by smk-ka. Displays some local tasks (not all).

Attachment	Size
admin_menu.patch	19.73 KB

sorry to ask here, but i'm interested by the patch and this time there's just too many things to modify:
how can I apply a patch file to a module file? which software do you use to automatically remove/add the lines in the patch?

Cheers,
James

@alliax: See http://drupal.org/patch/apply

subscribing. cheers!

Is it supposed to spit the menu out at the bottom in a unordered list format (does so with multiple core themes)? Just wondering, because my patch might of applied incorrectly. I didn't get any errors, but I had to get some old versions of files (admin_menu.info, .module, .inc) from CVS because the patch was out of date since it was created for an old dev version no longer available on the releases page.

subscribing.

i would be happy to test :) patching fails with 5.x-dev and 2.4 :(

I also tried tthe patch on 2.4: 3 out of seven hunks failed :( Daniel, gib dir einen Ruck, wir wollen doch auch in Drupal 6 aminmenuisieren - sorry for the german interlude

I would think you can do

Yay! Admin Menu rules!

Subscribing. Patch in 11 failed for me on 5.x-2.x-dev

Re-rolled patch against latest HEAD.

@chx: Thanks for your input! I've added your proposed code to admin_menu_tree_all_data(), commented-out for now, because:

returns all top level items of the 'navigation' menu instead of all items below the 'admin[ister]' menu item. However, we could work around this later.

The real question is: I do not understand, why the menu system only returns the top level items below 'admin' (i.e. "Content management", "Site building", aso.), but not all menu items below 'admin'.
If only 'mlid' is selected, it doesn't return any items below 'admin' at all.

Attachment	Size
admin_menu.patch	21.88 KB

Patch fails for me on admin_menu.info

But I got it working by manually applying the changes (woo hoo!). Some notes:

• 'Tools' links to admin/build/views (not what I expected?)
• 'Settings' links to admin/build/menu (again, not what I expected? just wondering if this functionality is by design)
• Hovering over a menu item now shows the url in the status bar in Firefox 2 (sweet!)

Thanks for working on this! I'm just working on porting my site over to D6 and this will make it much easier!

Subscribing. Any issues with the latest patch?

hello,

As many others here I really miss the admin menu on drupal 6, so should we ALL send few dollars with Paypal to expect getting it faster?

As this is the only thread about admin menu that I read I don't know so much about the future development of this menu for Drupal 6, so, sorry if I wrote something that had been discussed before.

Thanks anyway for this great module!

wwwoliondorcom, yes, that is probably the best idea to push this port. I've created a ChipIn for Drupal Administration Menu Port for D6, so everyone interested in this port can throw a few bucks in. I did not add a limit, however, due to the already identified issues regarding the new menu system this port will require a lot of hard work, maybe even a complete rewrite of the module.

I use this patch for 2.4 but got the error message:

And I also use this patch for 2008-Mar-20 version but still got error.

As written above, patch in #21 is against latest code in HEAD (in CVS).

Sorry, I just download the CVS but still get error.

Re-rolled patch against latest HEAD. Applies on a fresh CVS checkout only.

Attachment	Size
admin_menu.patch	21.74 KB

Applied patch in#29 to the latest CVS versions (cherry-picked from the repository since I don't know what I'm doing in there). No errors. The only issue I'm seeing at this point is that the favicon, logged users, and logout items are not displaying. Otherwise, the admin menus are working fine.

I applied patch #29 too, I think it's ok, thanks. How about release a snapshot for D6 and more people can help to test.

Sorry guys, it seems you got it wrong - please read comments #1 and #25 again. This port is far from complete, and if above patch partially works for you, that is caused by coincidence. In case you intend to use this on a production site, I do not recommend this, because there will be no support if something goes wrong.

Daniel, my comment wasn't meant to indicate that the patched module works perfectly; it was meant to offset the prior 7 comments indicating problems with the patch. You'll be happy to know that beyond the issues I mentioned, some of the menus do not have all the submenus I expect. :-)

Still, it's worth using on my 6.x sites because I'm still more productive.

Maybe we should chip in some money http://unleashedmind.chipin.com/drupal-administration-menu-port-for-d6 to give Daniel a strong incentive to investigate the depth of the new menu system ;) As seen from his comments, patches simply won't do. I fully understand that a maybe complete rewrite exceeds what he can do in his spare time.

Definitely! I've added my few hundred cents to ti ;-)

Just a reroll of patch #29 against HEAD (besides some fuzz, one hunk failed).
The port is still somewhat feature incomplete, but the most important things seem to work well enough for testing and maybe non-production usage.

Attachment	Size
admin_menu_d6.patch	21.17 KB

subscribing

Subscribing.

patch works for me... only basic functions, but it makes working so much nicer. Maybe we can release a first alpha version for D6 as I believe there will be lots of testers and a lot of users will appreciate it (even though some of the nice functionality is not in yet)

+1 to the patch in #36. Without the bells and whistles of the added local tasks, but still far better than any other admin option out there.

tracking

yes, if someone could post somewhere on the net the latest dev module file with the patch applied on it, it will be so fine. Anything like admin menu on D6 will be better than nothing or than this other module, I forgot the name but it was not good.

Last patch by Pancho (#36) was incomplete.
Re-rolled patch in #29 against latest HEAD. Applies on a fresh CVS checkout only.

I'll clean-up the existing code now and create a DRUPAL-6--1 branch, along with a development snapshot for 6.x. However, comment #32 still applies.

Attachment	Size
admin_menu.patch	21.48 KB

http://drupal.org/node/251566 should be available within the next 12 hours.

drupal.org/node/251566: access is denied to that node.

> Last patch by Pancho (#36) was incomplete.

Not a big thing, but I can't see why my patch should have been incomplete. It's been just slightly smaller, because Eclipse doesn't support the -p flag in diff.

@Pancho: Sorry, I was wrong. My diff tool was confused because the order of files in your patch was different.

Thank you very much for putting something for D6 even if not as useful as for D5, it's a timesaver anyway! Thanks.

great that a D6 version is available! even if it hasn't got all functionalities, I feel much more at home on my website again!

Joris

smk-ka and I spent some hours on this port this evening. Attached patch re-introduces base-functionality of Drupal Administration Menu we already had in Drupal 4.7.x. This means all local tasks in the administrative menu are back again. Additional improvements like direct access to create content items and all other add-ons are still missing.

Beware that your database user needs to have sufficient permissions to create temporary tables, and, this patch requires the MyISAM table engine currently.
This will hopefully change in an upcoming code-sprint. Currently, we are investigating the idea to store a mix of menu_router, menu_links, and hook_admin_menu() items in a new admin_menu table to eliminate the need for a temporary table.

Additionally, caching has been re-enabled. This will save you approx. 100ms on each page request.

While I really would like to get some feedback on this patch, I recommend to not use it unless you know how to revert your module to the last official release.

Attachment	Size
admin_menu.patch	7.39 KB

Since this port still needs much work and the previous ChipIn somehow ended too early:
http://unleashedmind.chipin.com/drupal-administration-menu-port-for-d6-2

Thanks to all who have contributed until now!