In several places in this file, drush_get_option is called in this form:

drush_get_option('option', 'context');

Should be:

drush_get_option('option', 'default value', 'context');
CommentFileSizeAuthor
#1 correct-drush-get-option-usage-1325302-1.patch2.51 KBsfyn

Comments

sfyn’s picture

sfyn commented
Title: drush_get_option is used incorrectly in install.provision.inc » drush_get_option is used incorrectly in install.provision.inc and migrate.provision.inc
Status: Active » Needs review
StatusFileSize
new correct-drush-get-option-usage-1325302-1.patch2.51 KB

Here is my patch

sfyn’s picture

sfyn commented
Priority: Normal » Minor
bgm’s picture

bgm commented
Status: Needs review » Fixed

Thanks for the patch!
Tested and committed to 6.x-1.x.

bgm’s picture

bgm commented

This patch is causing issues during the installation:

array_key_exists() expects parameter 2 to be array, null given in /var/aegir/.drush/provision_civicrm/provision_civicrm.drush.inc on line 124.

It seems that in most cases, we should completely omit the context, since drush_get_option() will anyway check site/platform/server, in that order.

sfyn’s picture

sfyn commented
Status: Fixed » Needs work

Would you like a new patch submitted?

bgm’s picture

bgm commented
Status: Needs work » Fixed

I have the impression things have been pretty much worked out by now. Closing the issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.