Problem/Motivation

From #1315886: Clean up API docs for includes directory, files starting with A-C. Inline comments for several functions in common.inc are missing capitalization and/or periods.

Proposed resolution

Attatched patch cleans up these comments.

Remaining tasks

Patch is RTBC.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#6 1326472-POST-APOCALYPSE-comment-cleanup.patch8.4 KBxjm
#1 1326472-1-comment-cleanup.patch8.37 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new 1326472-1-comment-cleanup.patch8.37 KB
xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Minor
lars toomre’s picture

lars toomre commented
Status: Needs review » Reviewed & tested by the community

All these changes look good and bring code closer to documentation standards.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -Needs backport to D7

#1: 1326472-1-comment-cleanup.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7

The last submitted patch, 1326472-1-comment-cleanup.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 1326472-POST-APOCALYPSE-comment-cleanup.patch8.4 KB
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Just a reroll so it's still RTBC. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nevets’s picture

nevets commented
Issue summary: View changes

Updated issue summary.