A port to D7 would be nice.

Comments

sanduhrs’s picture

StatusFileSize
new5.8 KB

Attached is a patch that upgrades the module to D7.
It also upgrades to the latest hoverIntent script.

As there's no D7 version of JQ it's just hook_library().

DruBerrymore’s picture

Could somebody please apply the patch in #1, and then make a 7.x-1.x-dev release.
Could somebody also be a co-maintainer.
This module is needed by the Giga Menu module.

a_c_m’s picture

sanduhrs - happy to give you co-maintainership if you want it. (Or would if i could work out how :P) May need help from aaron as i'm not 100% i have the power.

DruBerrymore’s picture

Would be happy to test it.

sanduhrs’s picture

Shure. On the project page click on the Maintainers tab - if you can ;)
[1] http://drupal.org/node/213818/maintainers

a_c_m’s picture

Yeah, i don't have access, sorry. Might need to message aaron direct. I will see if hes on IRC.

aaron’s picture

Status: Needs review » Fixed

Fixed the access, a_c_m. Thanks for your help, sanduhrs, you're in now!

aaron’s picture

Status: Fixed » Needs review

oops, status

sanduhrs’s picture

Thanks, aaron.
Just added a d7 dev release.

Please test and report back.

DruBerrymore’s picture

Don't see the d7 dev release on the project page.

sanduhrs’s picture

Well, it takes some time for the release to show up.
But you can already clone in from the repository: http://drupal.org/node/213818/git-instructions/7.x-1.x

stevetweeddale’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new2.57 KB

Just uploading this here in case the maintainers want it (I'll be using the patch in a drush make file regardless): I've added a dependency on libraries module and removed the hoverIntent js file from the module itself - the module would now just exposed the library to hook library. I believe this is the standard way of doing things nowadays. Hopefully at some point in the future libraries will be clever enough to not even require this kind of 'wrapper' module.

boonthanom’s picture

Hi,all
i would like to know step by step to run patch , so that my site have error messages as below

Hover intent not "installed in sites/default/libraries" The module will not work without it.
Hover intent not "installed in sites/default/libraries" The module will not work without it.

Thank you

stevetweeddale’s picture

Hi Boonthanom,

There is some javascript (the 'hoverintent' library itself) that was included in the module, but my patch removes it. This is closer to the general standard for this kind of module, where typically you download the integration module from Drupal.org and the external library from wherever the author publishes it.

So if you want to use my patched version, you'll need to download the library manually and put in sites/all/libraries. Otherwise, don't bother with my patch!

stephen ollman’s picture

Issue summary: View changes

Steve, what is the name of the folder that should be created in the libraries folder?

Is it 'hoverintent'?

I'm trying to use this within the muchmenus js code, replacing:

$('.muchomenu-parent-title').bind('mouseover', muchomenu_open);
$('.muchomenu-parent-title').bind('mouseout', muchomenu_timer);

with

$('.muchomenu-parent-title').hoverIntent(muchomenu_open, muchomenu_timer);

However after applying the patch and creating the library folder and file and also updating my template.php file, I'm still getting the error: TypeError: $(...).hoverIntent is not a function

  • sanduhrs committed a0a49e1 on 7.x-2.x
    Issue #1326790 by sanduhrs: Drupal 7 upgrade.
    
    
oadaeh’s picture

Status: Needs review » Fixed

I created a 7.x-2.x branch and committed different, minimal changes there to allow this module to work with the 2.x branch of the Libraries API module.
As there are a number of existing users for the 7.x-1.x branch, I am not making any changes in that branch that might break their sites.
Feel free to upgrade your hoverIntent and Libraries API modules to their 2.x branches to take advantage of the updates.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.