Posted by jenlampton on October 31, 2011 at 6:57am
1 follower
| Project: | Chaos tool suite (ctools) |
| Version: | 7.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
| Issue tags: | needs backport to D6 |
Issue Summary
I would really like a "parent term" selection rule (see #1327004: Taxonomy: term parent (TID / name) selection rule please :)). Unfortunately, this is not that. What this is, is really a "has parent" selection rule. Can we please rename it as such?
Comments
#1
#2
On second thought, we should probably rename the whole file (and all functions within)
#3
it looks like this was already done in the D7 version. :/ perhaps we just need a backport.
#4
My thought is not to rename the whole inc file as to not get in the way of D7. Let's just clean up the UI so people know what the heck is going on.
#5
The names for these two access rules are backwards.
Term has parent(s)is boolean: does the term have parent(s)? yes/no.But the config form asks you to choose specific parents.
Parent termshould need to be specified: Which is the parent term?But in this case you just select a vocabulary (uhm, what?!)
I propose the following cleanup:
1) Change the names of the two selection rules.
Proposed new names:
- "Taxonomy: term has any parent"
- "Taxonomy: parent term (specify)"
"Taxonomy: term has any parent" selection rule config cleanup
2) Remove the confusing vocabulary option on the config form as per #1343144: Remove Vocabulary select box from "Taxonomy: parent term" selection rule
"Taxonomy: parent term (specify)" selection rule config cleanup
3) Update the Description text on all the form elements that will help users choose wisely, as per #1889572: Clean up description text on Taxonomy term parent access rule config form
Attached patch is limited to the name change.