drupal's feed icon
hass - March 31, 2007 - 11:03
| Project: | Site map |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | frjo |
| Status: | closed |
Description
please use the drupal feed icon inside the sitemap. It looks really nicer and is something the user remembers...
#1
I like the feed icon Drupal uses, it's the closest we have to a standrad since Firefox as well as IE 7 is using it.
For list I find it difficult to use in a nice way, it tends to be a bit to big.
#2
i know, let's resize it... no problem...
#3
Here is the patch that fixes this issue. The images are following. Put them both in a directory named "img".
Additional it fixes a XHTML validaion bug if the "site_map_message" is blank (don't hurt me for mixing this up...).
#4
this is the feed icon in 12x12. place into "site_map/img" folder
#5
this is the feed icon for commented feeds in 12x12. place into "site_map/img" folder, too
#6
Thanks hass! Committed a little modified version of your patch and the images to HEAD. Please try it out and report any issues here.
#7
thank you, changes look nice, too. i found one bug... i found this while developing, but missed to include :-(((.
All theme_site_map_feed_icons URLs needs url() function... if not all links are broken :-(.
Example:
theme('site_map_feed_icon', url("taxonomy/term/$term->tid/$rss_depth/feed"));#8
here is a patch for the URL bug. Aside you missed to fix the CSS file... patch fixes both.
#9
this patch was build in the same way like
$block['content'] = theme('feed_icon', url($feedurl));was build...
#10
Committed to HEAD, the links should now be correct, thanks.
I decided to skip the css file altogether.
#11
if you skip the css, you will have a background color definied, where it is not required... a color and font-size that is senseless, while you don't have text... makes no sense to keep it. And the padding with EM is better for many themes... and different platforms.
#12
What I meant was that I don't think the site_map module needs a CSS file at all anymore. I have removed the call to drupal_add_css() in HEAD.
#13
yes, ok.
#14
#15