Download & Extend
Site map » Issues

drupal's feed icon

Posted by hass on March 31, 2007 at 11:03am
Project:Site map
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:frjo
Status:closed (fixed)

Issue Summary

please use the drupal feed icon inside the sitemap. It looks really nicer and is something the user remembers...

Login or register to post comments

Comments

#1

Posted by frjo on April 23, 2007 at 7:29am

I like the feed icon Drupal uses, it's the closest we have to a standrad since Firefox as well as IE 7 is using it.

For list I find it difficult to use in a nice way, it tends to be a bit to big.

#2

Posted by hass on April 23, 2007 at 7:45am

i know, let's resize it... no problem...

#3

Posted by hass on May 26, 2007 at 10:49pm
Status:active» needs review

Here is the patch that fixes this issue. The images are following. Put them both in a directory named "img".

Additional it fixes a XHTML validaion bug if the "site_map_message" is blank (don't hurt me for mixing this up...).

AttachmentSize
site_map.feed-icon.patch 6.19 KB

#4

Posted by hass on May 26, 2007 at 10:50pm

this is the feed icon in 12x12. place into "site_map/img" folder

AttachmentSize
feed-icon-12x12.png 552 bytes

#5

Posted by hass on May 26, 2007 at 10:50pm

this is the feed icon for commented feeds in 12x12. place into "site_map/img" folder, too

AttachmentSize
feed-icon-12x12-comment.png 734 bytes

#6

Posted by frjo on May 28, 2007 at 2:11am
Assigned to:Anonymous» frjo
Status:needs review» postponed (maintainer needs more info)

Thanks hass! Committed a little modified version of your patch and the images to HEAD. Please try it out and report any issues here.

#7

Posted by hass on May 28, 2007 at 9:20am
Status:postponed (maintainer needs more info)» needs work

thank you, changes look nice, too. i found one bug... i found this while developing, but missed to include :-(((.

All theme_site_map_feed_icons URLs needs url() function... if not all links are broken :-(.

Example:

theme('site_map_feed_icon', url("taxonomy/term/$term->tid/$rss_depth/feed"));

#8

Posted by hass on May 28, 2007 at 9:28am
Status:needs work» needs review

here is a patch for the URL bug. Aside you missed to fix the CSS file... patch fixes both.

AttachmentSize
site_map.url_.patch 4.88 KB

#9

Posted by hass on May 28, 2007 at 9:42am

this patch was build in the same way like

$block['content'] = theme('feed_icon', url($feedurl));

was build...

#10

Posted by frjo on May 28, 2007 at 12:02pm

Committed to HEAD, the links should now be correct, thanks.

I decided to skip the css file altogether.

#11

Posted by hass on May 28, 2007 at 3:11pm

if you skip the css, you will have a background color definied, where it is not required... a color and font-size that is senseless, while you don't have text... makes no sense to keep it. And the padding with EM is better for many themes... and different platforms.

#12

Posted by frjo on May 30, 2007 at 5:42am

What I meant was that I don't think the site_map module needs a CSS file at all anymore. I have removed the call to drupal_add_css() in HEAD.

#13

Posted by hass on May 30, 2007 at 10:16pm

yes, ok.

#14

Posted by frjo on June 2, 2007 at 4:24am
Status:needs review» fixed

#15

Posted by Anonymous on June 16, 2007 at 4:48am
Status:fixed» closed (fixed)
nobody click here