Comments

killes@www.drop.org’s picture

StatusFileSize
new2.71 KB

Updated to return to the page you came from after doing updates. Should preserve sort order and page number. Needs testing.

yched’s picture

Big +1 on the principle.

SQL error when sorting on, say, Node Type :
SELECT n.*, u.name, u.uid FROM node n INNER JOIN users u ON n.uid = u.uid ORDER BY n.changed DESC ORDER BY n.type ASC LIMIT 0, 50
(two ORDER BY instances in the query)

yched’s picture

And a notice when you arrive on the page :
Undefined index: sql in includes\tablesort.inc on line 41.

gerhard killesreiter’s picture

StatusFileSize
new2.68 KB

Fixed the sql, I didn't see the notice after that. The redirect back after deletion doesn't work, apparently $_GET gets lost during _submit. Maybe we'll need to set a session variable.

bdragon’s picture

Status: Needs review » Needs work

Autopatch Results:
patching file modules/node/node.module
Hunk #1 succeeded at 1581 with fuzz 1 (offset 96 lines).
Hunk #2 FAILED at 1617.
Hunk #3 FAILED at 1664.
Hunk #4 FAILED at 1727.
3 out of 4 hunks FAILED -- saving rejects to file modules/node/node.module.rej

pasqualle’s picture

Status: Needs work » Needs review
StatusFileSize
new2.63 KB

part of the patch rerolled with minor changes
the missing part does not make sense to me, and seems hacky

problems:
the default sort is invisible (n.changed) and therefore the default sort can not be set back easily (e.g. click filter and undo)

off topic question:
the language is checked by locale module. why not content translation module?

pasqualle’s picture

Title: Add sortable header to form at admin/node/content » Add sortable header to form at admin/content/node
moshe weitzman’s picture

Status: Needs review » Needs work
pancho’s picture

Assigned: killes@www.drop.org » Unassigned
Status: Needs work » Closed (duplicate)

Marking this a duplicate of #213151, as the other patch covers the same and is more up to date.