Closed (duplicate)
Project:
Drupal core
Version:
6.x-dev
Component:
node system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Mar 2007 at 12:36 UTC
Updated:
8 Feb 2008 at 01:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
killes@www.drop.org commentedUpdated to return to the page you came from after doing updates. Should preserve sort order and page number. Needs testing.
Comment #2
yched commentedBig +1 on the principle.
SQL error when sorting on, say, Node Type :
SELECT n.*, u.name, u.uid FROM node n INNER JOIN users u ON n.uid = u.uid ORDER BY n.changed DESC ORDER BY n.type ASC LIMIT 0, 50
(two ORDER BY instances in the query)
Comment #3
yched commentedAnd a notice when you arrive on the page :
Undefined index: sql in includes\tablesort.inc on line 41.
Comment #4
gerhard killesreiter commentedFixed the sql, I didn't see the notice after that. The redirect back after deletion doesn't work, apparently $_GET gets lost during _submit. Maybe we'll need to set a session variable.
Comment #5
bdragon commentedAutopatch Results:
patching file modules/node/node.module
Hunk #1 succeeded at 1581 with fuzz 1 (offset 96 lines).
Hunk #2 FAILED at 1617.
Hunk #3 FAILED at 1664.
Hunk #4 FAILED at 1727.
3 out of 4 hunks FAILED -- saving rejects to file modules/node/node.module.rej
Comment #6
pasquallepart of the patch rerolled with minor changes
the missing part does not make sense to me, and seems hacky
problems:
the default sort is invisible (n.changed) and therefore the default sort can not be set back easily (e.g. click filter and undo)
off topic question:
the language is checked by locale module. why not content translation module?
Comment #7
pasqualleComment #8
moshe weitzman commentedComment #9
panchoMarking this a duplicate of #213151, as the other patch covers the same and is more up to date.