Download & Extend

Please add a link to update.php on the admin/logs/updates page

Project:Update Status
Version:5.x-1.0
Component:User interface
Category:feature request
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The Available Updates page lists all modules that have a newer version. It gives links to download the updated module. What it doesn't yet have is a direct link to the update.php page. Users click the link to download a new module, switch to their FTP program to make the upload, and then switch back to the browser, whereupon they are greeted with, well, nothing helpful.

I added a link to update.php on some of my sites. Here's the patched update_status.module in case anyone else wants this user experience feature too.

AttachmentSize
update_status_1.patch10.28 KB

Comments

#1

Priority:normal» minor

a) that's not a patch. please see http://drupal.org/patch

b) the /admin page already tells you if your schema is out of date an update.php should be run. i'm not convinced this module should duplicate that effort.

c) update_status.module doesn't have any way of knowing if an updated module will include a schema update. so, the only way to figure that out is to actually update the module, first. *all* kinds of documentation, the help text on and the /admin/build/modules page, and the /admin page, all tell you that after you update, you should be sure to run update.php. if you just switch back to your browser window which is still pointing to admin/logs/update, nothing will change unless you reload the page. and at that point, you'd expect it to say "there are no updates available -- your site is up to date", which is now true.

i *suppose* we could add something to the help text there, but your instructions are far too specific to one particular use-case for how people run their sites. i never download to my laptop, then upload with ftp, etc, etc. the only thing that's generally true is "After you install the latest version(s) of each module listed below, you should run update.php to make sure your database is also up to date" (or something).

if you're so inclined, please attach a patch that *only* adds that sentence (or something like it) to the help text. no other page in the drupal UI says "this page was rendered by the foo.module", so please leave that out.

thanks,
-derek

#2

I'm generally in agreement with dww. We don't know what the user's flow is going to be to update their module physically, and it changes a lot. The modules page contains code to see if update.php needs to be run.

I might be interested in a patch that can re-use that code. If that's possible, its' only a one or two line patch to update_status and it makes perfect sense. But otherwise, adding 'be sure to run update.php after updating' to the text is as far as I'd be willing to go.

#3

Well dww, I have read drupal.org/patch. It doesn't make mention of this situation. I am still learning about how you guys all work on things too. I think what you're saying is that I went too far in changing the help text, and that's why it's not a patch? If not, I need to understand what you guys consider a helpful patch. I'd better go watch addison's video again.

BTW, I uploaded that modified module file directly from one of my own sites. I didn't think you'd actually use the file I uploaded, since there's no way to tell if I might have screwed something up in the code. I was thinking that you'd just use the concept I demonstrated. Here's hoping that nobody puts anything I code into the world-at-large without a serious background check!

Merlin, the only reason an update.php link should be generated onto the page I'm demoing to you is that a user will most often come directly back to that page after uploading the new module via FTP or moving an updated copy of the module on their localhost server. It's simply a matter of convenience to have that link there waiting for them upon their return, and does not necessarily rely on anything having to do with another drupal page, nor should it be dynamically generated in certain use cases. It's a user convenience link, and that's all. The more little details like this in Drupal, the better it seems as a CMS. Peoples will start thinking, "Hey! They thought of me when they built this thing!".

I won't be submitting another file as a patch for this issue. You guys can use the code in the one I already uploaded should you decide that the little details are worth it to the end user. I will try to discern what makes a good patch, and try again soon. :=)

#4

it's not a patch because it's not a small file generated by diff or cvs diff that just contains the changes you made, it's your entire copy of the modified update_status.module file. if http://drupal.org/patch wasn't clear enough, perhaps try http://drupal.org/patch/background and http://drupal.org/patch/create.

thanks,
-derek

#5

Status:active» closed (fixed)

I'm closing my own issue because I don't feel like working on this one again. There's far more exciting things going on with the looking D6 release.