Problem/Motivation

To view a summary of the default meta tags and the inheritance, you can only click on a meta tag type name.

Proposed resolution

Make the entire div clickable including the background arrow.

Remaining tasks

None

User interface changes

Entire meta tag type area now clickable to see summary.

API changes

None

Comments

andremolnar’s picture

StatusFileSize
new1.31 KB

Attached patch for that.

marcoka’s picture

Status: Active » Needs review

i am not sure of this. this does not fit with other modules handling (backend consistentcy)

andremolnar’s picture

This is going a while back now, but if I recall correctly the motivation was the UX expectation that the arrows be clickable.

This patch provides an overall better user experience with little to no drawbacks (that I can think of). If there are other modules that do not follow this pattern today, perhaps they will follow this lead.

marcoka’s picture

arrows are great, agree. but dint you mention that the whole div area is clickable too?

andremolnar’s picture

Yes, its all clickable. The arrows are implemented as background images on the div - so its the div that must be clickable (or else re-write the entire display and add a ton of tag soup).
Have you tried it out to see it in action? It works quite nicely if I do say so myself :)

marcoka’s picture

ok, i know what you mean. i think in the end it depends on the maintainers. i am so familiar with ui stuff that i would not have problems with the current or your suggestion.

damienmckenna’s picture

StatusFileSize
new1.26 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, metatag-n1327614-7.patch, failed testing.

damienmckenna’s picture

Version: 7.x-1.0-alpha3 » 7.x-1.x-dev
damienmckenna’s picture

Status: Needs work » Needs review

#7: metatag-n1327614-7.patch queued for re-testing.

damienmckenna’s picture

Status: Needs review » Fixed

Great little improvement, thank you andremolnar for the contribution. Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.