Logged in, url() is using up 470ms on our servers. I'm able to get this down to 87ms or so with some interesting caching.

CommentFileSizeAuthor
#11 drupal-cache-url-1327720-11.patch4.49 KBmikeytown2
#9 drupal-cache-url-1327720-9.patch4.41 KBmikeytown2
#7 drupal-cache-url-1327720-7.patch4.33 KBmikeytown2
#5 drupal-cache-url-1327720-5.patch4.41 KBmikeytown2
#3 drupal-cache-url-1327720-3.patch4.41 KBmikeytown2
#2 drupal-cache-url-1327720-2.patch4.38 KBmikeytown2
#1 drupal-cache-url-1327720-1.patch4.3 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new drupal-cache-url-1327720-1.patch4.3 KB

The late_cache_set_merge_locked function should be moved to cache.inc most likely; but its in here for now.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new drupal-cache-url-1327720-2.patch4.38 KB

Slight efficiency improvements.

mikeytown2’s picture

mikeytown2 commented
Issue summary: View changes

Updated issue summary.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new drupal-cache-url-1327720-3.patch4.41 KB

forgot to release the lock

Status: Needs review » Needs work

The last submitted patch, drupal-cache-url-1327720-3.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-cache-url-1327720-5.patch4.41 KB

Status: Needs review » Needs work

The last submitted patch, drupal-cache-url-1327720-5.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Title: Cache the URL function » Cache url()
Status: Needs work » Needs review
StatusFileSize
new drupal-cache-url-1327720-7.patch4.33 KB

Status: Needs review » Needs work

The last submitted patch, drupal-cache-url-1327720-7.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-cache-url-1327720-9.patch4.41 KB

Status: Needs review » Needs work

The last submitted patch, drupal-cache-url-1327720-9.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-cache-url-1327720-11.patch4.49 KB
vasrush’s picture

vasrush commented

#11: drupal-cache-url-1327720-11.patch queued for re-testing.

rjbrown99’s picture

rjbrown99 commented

There is a report that #11 breaks Open Atrium menus. I do not know if this is an OA problem or an issue with the patch, but it's worth mentioning here.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Needs work

Too many reports of this causing issues.
lock_acquire() is taking too long. If it didn't have a while loop, it might be viable. See memcache version of lock_acquire() for some ideas to move this forward.

mikeytown2’s picture

mikeytown2 commented

Found a patch where someone is caching below this at the url_alias level for taxonomy terms.
http://groups.drupal.org/node/97794#comment-828593

jcisio’s picture

jcisio commented
Version: 6.x-dev » 8.x-dev

D8 first? custom_url_rewrite_outbound() (or hook_url_outbound_alter()) result is cacheable? I think we should bypass the cache in case there is a hook implementation.

pwolanin’s picture

pwolanin commented
Status: Needs work » Closed (duplicate)

outdated and duplicate to #1965074: Add cache wrapper to the UrlGenerator

pwolanin’s picture

pwolanin commented
Issue summary: View changes

Updated issue summary.