Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Logged in, url() is using up 470ms on our servers. I'm able to get this down to 87ms or so with some interesting caching.
Comment | File | Size | Author |
---|---|---|---|
#11 | drupal-cache-url-1327720-11.patch | 4.49 KB | mikeytown2 |
#9 | drupal-cache-url-1327720-9.patch | 4.41 KB | mikeytown2 |
#7 | drupal-cache-url-1327720-7.patch | 4.33 KB | mikeytown2 |
#5 | drupal-cache-url-1327720-5.patch | 4.41 KB | mikeytown2 |
#3 | drupal-cache-url-1327720-3.patch | 4.41 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedThe late_cache_set_merge_locked function should be moved to cache.inc most likely; but its in here for now.
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedSlight efficiency improvements.
Comment #2.0
mikeytown2 CreditAttribution: mikeytown2 commentedUpdated issue summary.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedforgot to release the lock
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedComment #7
mikeytown2 CreditAttribution: mikeytown2 commentedComment #9
mikeytown2 CreditAttribution: mikeytown2 commentedComment #11
mikeytown2 CreditAttribution: mikeytown2 commentedComment #12
vasrush CreditAttribution: vasrush commented#11: drupal-cache-url-1327720-11.patch queued for re-testing.
Comment #13
rjbrown99 CreditAttribution: rjbrown99 commentedThere is a report that #11 breaks Open Atrium menus. I do not know if this is an OA problem or an issue with the patch, but it's worth mentioning here.
Comment #14
mikeytown2 CreditAttribution: mikeytown2 commentedToo many reports of this causing issues.
lock_acquire() is taking too long. If it didn't have a while loop, it might be viable. See memcache version of lock_acquire() for some ideas to move this forward.
Comment #15
mikeytown2 CreditAttribution: mikeytown2 commentedFound a patch where someone is caching below this at the url_alias level for taxonomy terms.
http://groups.drupal.org/node/97794#comment-828593
Comment #16
jcisio CreditAttribution: jcisio commentedD8 first? custom_url_rewrite_outbound() (or hook_url_outbound_alter()) result is cacheable? I think we should bypass the cache in case there is a hook implementation.
Comment #17
pwolanin CreditAttribution: pwolanin commentedoutdated and duplicate to #1965074: Add cache wrapper to the UrlGenerator
Comment #17.0
pwolanin CreditAttribution: pwolanin commentedUpdated issue summary.