Submitted data not decrypted when form components are inside fieldsets

I'm experiencing this on D6.

(I'm using version 6.x-1.x-dev, datestamp 1307580853)

Perhaps I'm not experiencing the same thing, as in my case the data is indeed being encrypted and decrypted properly, it's just being printed un-themed at the beginning of the $content variable output because the render array is getting messed up.

On webform_encrypt.module line 97 the form_key is being discovered improperly for fields that live inside fieldsets:

<?php
$form_key = $renderable['#node']->webform['components'][$cid]['form_key'];
?>

which is then inserted into

<?php
$renderable[$form_key]['#value']
?>

but that is not a real value when the field lives inside a fieldset. It's something like $renderable['fieldset_name'][$form_key]['#value']. The code below should work for an infinite amount of fieldsets, although it kind of brute forces it. If anyone has suggestions on how to make it more efficient please post your thoughts.

<?php
/**
 * Implementation of hook_webform_submission_render_alter().
 * Decrypt values when displaying webform submissions.
 */
function webform_encrypt_webform_submission_render_alter(&$renderable) {
  // First, determine if 1) if we are dealing with an email or a page view, and 2) if user matching
  // is enabled.
  if (variable_get('webform_encrypt_match_user', 0) && !empty($renderable['#email'])) {
    // If we are, then try to match a user to the email address we are sending to.
    $uid = db_result(db_query('SELECT uid FROM {users} WHERE mail = "%s"', array($renderable['#email']['email'])));
    $account = $uid ? user_load($uid) : NULL;
  } else {
    $account = NULL;
  }

  // Next, we loop through components and decrypt as necessary.
  foreach ($renderable['#submission']->data as $cid => $entry) {
    if (isset($renderable['#node']->webform['components'][$cid]['extra']['encrypt']) &&
        $renderable['#node']->webform['components'][$cid]['extra']['encrypt']) {
      $form_key = $renderable['#node']->webform['components'][$cid]['form_key'];
      if (user_access('view encrypted values')) {
        $decrypted_value = decrypt($entry['value'][0], array('base64' => TRUE));;
        if (key_exists($form_key, $renderable)) {
          $renderable[$form_key]['#value'] = $decrypted_value;
        } else {
          foreach ($renderable as $key => &$value) {
            _webform_encrypt_webform_submission_render_alter_helper($value, $form_key, $decrypted_value);
          }
        }
      } else {
        $renderable[$form_key]['#value'] = t('[Value Encrypted]');
      }
    }
  }
}

function _webform_encrypt_webform_submission_render_alter_helper(&$value, $form_key, $decrypted_value) {
  if (is_array($value) && isset($value['#type']) && $value['#type'] == 'fieldset') { // Look inside of it.
    if (key_exists($form_key, $value)) {
      $value[$form_key]['#value'] = $decrypted_value;
    } else {
      _webform_encrypt_webform_submission_render_alter_helper(&$value, $form_key, $decrypted_value);
    }
  }
}
?>

Will the above code work for D7?

Will the above code work for D7?

I think you need to open a separate issue for D7 version.

But, go ahead and take a look at webform_encrypt.module in the 7.x-dev branch and see if the same thing is happening that I described above.

This is really an issue with the form api and fieldsets. The same issue comes up using hook_form_alter. The only dependable way to find where the real field definition data in a fieldset is stored is to walk recursively down the form looking for the field name just as the solution above shows. If you don't, its very simple to think you've found the actual part of the structure you want only to have the wrong area of the structure.

I have implemented a different approach for D7, didn't see this post until I had finished working on my patch.

The D7 patch can be found here #1503786: Encrypted items inside a fieldset are not decrypted when submission is viewed.

I did think of using a helper function like the above patch but in the end I used the parent IDs.

Duplicate of #1503786: Encrypted items inside a fieldset are not decrypted when submission is viewed.

Tested encrypted fieldset data