Table header have unsufficient columns if Taxonomy Images integration is on [#1328152]

Posted by RedRat on November 1, 2011 at 10:33am

4 followers

Issue Summary

First of all, excuse my English.

If Taxonomy Image integration is on, then one more column (sixth) is added to the forum table, but number of columns in the table header remains the same (five). Because of it all captions shifted to wrong column. You can see results on attached screenshots.

Attachment	Size
taxonomy_image_off.gif	5.67 KB
taxonomy_image_on.gif	5.98 KB

Comments

#1

Posted by Michelle on November 1, 2011 at 1:03pm

Hmm... I'm pretty sure this was fixed at one point. I remember the patch. Don't have time to test to see if it got reverted somehow, though.

Michelle

#2

Posted by mcdruid on November 14, 2011 at 11:16pm

I think this is probably the issue / patch you're thinking of Michelle: #1015118: naked style colspan bug with taxonomy_image module enabled

...however it looks like advanced_forum.naked.forum-list.tpl.php has changed a bit since then.

I'll have a proper look when I'm on my dev machine.

#3

Posted by Michelle on November 15, 2011 at 2:24am

Yeah, that's the one I'm thinking of.

Michelle

#4

Posted by mcdruid on November 15, 2011 at 9:18am

RedRat, could you try this patch please?

Attachment	Size
table_header_colspan_for_taxonomy_image-1328152.patch	952 bytes

#5

Posted by RedRat on November 16, 2011 at 11:11am

Status:

active

» reviewed & tested by the community

I have tried patch from #4 and it works fine. Just a little suggestion for it:

<th class="forum-icon"<?php if ($use_taxonomy_image) print ' colspan="2"'; ?>>

#6

Posted by RedRat on November 16, 2011 at 11:40am

BTW, is taxonomy icons have to be added to original forum icons, or have to replace them? Now I see two icons for every forum, one from original forum theme and another from taxonomy.

#7

Posted by mcdruid on November 16, 2011 at 1:27pm

Thanks for testing RedRat, and yes your suggestion looks like it would work fine - I was trying to stay consistent with the code which does something similar a few lines further down in the same file.

I'll get the fix committed shortly.

As for removing the default icons, there are a few support requests about that in the queue - try searching for 'taxonomy image'.

e.g. #1221444: How to change category pictures like Coulee Region forums