When I check my watchdog logs, I always wonder if any of the searches didn't return any results. There is only one way to learn it, searching the same keywords again which creates another watchdog entry.

Attached patch :
- improves the search page (web/search/node) for the user and its watchdog message (admin/reports/dblog) for the admin by adding number of search results and the elapsed time.

You can see the differences for the search result display in the screenshot.

CommentFileSizeAuthor
#6 detailed_search_log_3.patch2.71 KBpasqualle
#3 detailed_search_log-2.patch2.81 KBerdemkose
#2 detailed_search_view.png29.65 KBerdemkose
#1 detailed_search_log.png19.96 KBerdemkose
detailed_search_log.patch2.79 KBerdemkose

Comments

erdemkose’s picture

erdemkose commented
StatusFileSize
new detailed_search_log.png19.96 KB

screenshot of watchdog entry

erdemkose’s picture

erdemkose commented
StatusFileSize
new detailed_search_view.png29.65 KB

screenshot of search results

Please feel free to change the wordings in the patches.

erdemkose’s picture

erdemkose commented
StatusFileSize
new detailed_search_log-2.patch2.81 KB

right patch

Dublin Drupaller’s picture

Dublin Drupaller commented

nice one erdemkose. just thought I'd post a message to say your patch works with the search.module for Drupal 4.7.5 as well..

Dub

keith.smith’s picture

keith.smith commented
Status: Needs review » Needs work

# patch -p0 < detailed_search_log-2.patch
patching file modules/search/search.module
Hunk #1 succeeded at 928 (offset 28 lines).
Hunk #2 FAILED at 945.
patch unexpectedly ends in middle of line
Hunk #3 succeeded at 1285 with fuzz 1 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file modules/search/search.module.rej

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new detailed_search_log_3.patch2.71 KB

I really like this feature
rerolled with minor changes

problems:
1. there should be a problem with pager, I did not test that
2. the search statistics should be above the results, as it is displayed on picture #2

need some help from someone who better understand this theming stuff here

3. part of the watchdog message is stored as translated
'@result' => format_plural($pager_total_items[0], '1 match', '@count matches')

how should I correct this?

birdmanx35’s picture

birdmanx35 commented
Version: 6.x-dev » 7.x-dev
Status: Needs review » Needs work

This is a feature change, and feature changes go to 7.x-dev.

Also, there are unresolved comments as per the last comment, so I'm setting this to CNW.

Jaza’s picture

Jaza commented
Version: 7.x-dev » 8.x-dev

Bump.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes

This still seems like a useful feature for Core.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Sure... Right now my priority is to fix the bugs in search.module, so it is unlikely that this feature will be addressed. We would also have to consider the performance implications of this change.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.0.x-dev » 8.1.x-dev

Since 8.0.x-beta1 has been released, our policy at this point is No feature requests until 8.1.x. See #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Sorry, it's just too late for 8.0.x at this point, so even if we had a viable patch, the core committers would not commit it. So unless we decide this is a Task or a Bug (and I don't think it is), we'll have to delay it.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

johnv’s picture

johnv
Primary language Dutch
commented
Title: Display result count in watchdog » Add 'total number of items' to search results and its watchdog log
Issue summary: View changes
oily’s picture

oily commented
Issue tags: +Needs tests

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.

Search will be moved to a contributed project before Drupal 12.0.0 is released.