Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Seven theme
Priority:
Minor
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
1 Nov 2011 at 14:39 UTC
Updated:
29 Jul 2014 at 20:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
chi commentedComment #3
chi commented#1: clean_up_css_in_seven-theme-1328378-0.patch queued for re-testing.
Comment #4
chi commentedTagging for backport.
Comment #5
aspilicious commented... I've seen these mistakes before...
note: #393 is kinda blue-ish
Comment #6
jacineNice catch. :)
Comment #7
webchickThis is tagged for backport to D7. Can you explain (or better yet, demonstrate with screenshots) what the visual effects of this patch are? And if there are none, explain why?
Comment #8
jacine@webchick In the above code
color: greenis always used, because it comes last, so there's no visual change. #393 is also green (it's just a tad lighter). It's basically how CSS works. The browser renders the last property it understands. So, you could have 20 different colors defined and the last one will always win.The person who coded this was probably just playing around with colors and forgot to remove the first one. There are no visual changes and it would have no effect on themes that have overridden it or anything like that, so it's totally safe for backport to D7.
Comment #9
chi commentedNo visual effects. It just makes code clear.
Comment #10
webchickLOL. OMG I'm rusty with CSS. Duh. Thanks for pointing that out.
Committed and pushed to 8.x and 7.x. Thanks. :)