subsites.install update 7200 not quite D7 ready (solution) [#1328478]

function subsites_update_7200() isn't quite ready for primetime. But here's a fix:

From (line 149):

    $fid = db_query("SELECT 1 FROM {file_managed} WHERE url = :url", array(':url' => subsites_get_css_path($subsite->sid)))->fetchField();
    if ($fid) {
      db_update('subsites')
        ->fields(array(
          'css_fid' => $fid
        ))
        ->condition('sid', $subsite->sid)
        ->execute();
    }

To (line 149):

    $fm_result = db_query("SELECT * FROM {file_managed} WHERE uri = :uri", array(':uri' => subsites_get_css_path($subsite->sid)))->fetchField();
	$fm_file = array_shift($fm_result);
    if (!empty($fm_file->fid)) {
      db_update('subsites')
        ->fields(array(
          'css_fid' => $fm_file->fid
        ))
        ->condition('sid', $subsite->sid)
        ->execute();
    }

Comments

Comment #1

m4olivei

he/him

English

Grimsby, ON

commented 24 April 2013 at 14:28

Hello,

This issue and others are fixed in my patch over at:

http://drupal.org/node/800880

Thanks,
Matt

Comment #1.0

m4olivei

he/him

English

Grimsby, ON

commented 24 April 2013 at 14:28

Issue summary:

View changes

Missing )

Comment #2

chunty commented 5 May 2014 at 20:22

Issue summary:

View changes

Am I right in thinking there was an error still with your patch over at http://drupal.org/node/800880

I ended up with this at 184:

foreach ($result as $subsite) {
    $fid = db_query("SELECT 1 FROM {file_managed} WHERE url = :url", array(':url' => subsites_get_css_path($subsite['sid'])))->fetchField();
    if ($fid) {
      db_update('subsites')
        ->fields(array(
          'css_fid' => $fid
        ))
        ->condition('sid', $subsite['sid'])
        ->execute();
    }
  }

which I think should have been:

foreach ($result as $subsite) {
    $fid = db_query("SELECT 1 FROM {file_managed} WHERE uri = :uri", array(':uri' => subsites_get_css_path($subsite->sid)))->fetchField();
    if ($fid) {
      db_update('subsites')
        ->fields(array(
          'css_fid' => $fid
        ))
        ->condition('sid', $subsite->sid)
        ->execute();
    }
  }