After #22336: Move all core Drupal files under a /core folder to improve usability and upgrades I needed to port this 'module' to D8 to get my D8 site back up and running. Hope this helps someone else.

Comments

neclimdul’s picture

how do install this and run it with d7 sites?

neclimdul’s picture

Sorry that was a bit terse(pre coffee) comment. What I mean is I created #1332950: Support 8.x post /core move because I wasn't looking for a port, I was looking for support. You don't install different versions of drush scripts, drush commands are expected to work in different version of Drupal because of how its used.

Also, I'm looking for something that will help me bisect across the /core move which means it sort of needs to support 2 states of drupal8 which is going to be... special...

rfay’s picture

Sorry - I must have misunderstood... I agree that the drush part will have to handle the multiple versions successfully. Not going to be able to help with the git bisect I don't think :-)

neclimdul++

neclimdul’s picture

Would be less an issue if this existed in core and and was translated across the move... ;)

rfay’s picture

I pretty much think this should exist in at least drush core but probably drupal core, as you say.

rfay’s picture

@wojtha marked #1328718: D8 port as a duplicate of this one.

wojtha’s picture

StatusFileSize
new4.99 KB

I didnt noticed the issue so I created the issue #1335558: Port to Drupal 8 independently (now closed as duplicate).

Here is my patch. The only difference is that I'm trying to enable the Entity module (I migrated today from the state when the entity was part of the common shared libraries).

rfay’s picture

Probably better to at least say "entity module was enabled if it existed" or act based on the db_update. No biggie though.

Is it always reasonable to enable entity just because it's discovered in the system table?

rfay’s picture

Status: Needs review » Needs work

I tried out #7 and was able to get out of hell on my D8 install using the php registry_rebuild.php approach, but the drush integration doesn't seem to be right yet:

PHP Fatal error:  Call to undefined function registry_get_parsed_files() in /home/rfay/.drush/registry_rebuild.drush.inc on line 61
rfay’s picture

@wojtha could you explain why you need to independently enable entity module? It seems to me if it was already enabled, that's good... if not...

rfay’s picture

Status: Needs work » Needs review
StatusFileSize
new4.95 KB

Here's a version that works for me on D7 and D8.

rfay’s picture

Status: Needs review » Fixed

Committed: http:/drupalcode.org/project/registry_rebuild.git/commitdiff/a1881e1

Certainly open to improvements.

rfay’s picture

Had to follow up with http://drupalcode.org/project/registry_rebuild.git/commitdiff/2154391 since I broke D7 drush.

wojtha’s picture

@rfay #18, I had older codebase of D8 before "corepocalypse" and when entity was a common library (entity.inc) not a module. But now entity isn't common library but a required module, needed early in the bootstrap...

So basically it fixes the transition from the state before that commit:

commit 58a5b82f90d0d92bd58ca6eb18bd936b5b7eb083
Author: Dries Buytaert <dries@buytaert.net>
Date:   Wed Sep 21 06:09:49 2011 -0400

    - Patch #1018602 by fago, catch, aspilicious: move entity system to a module.
rfay’s picture

Status: Fixed » Needs work

OK, thanks.

rfay’s picture

Status: Needs work » Fixed

Since so much time has passed and we'd assume the older d8 code is gone, I'm moving this back to fixed. If there are any issues, I'm still happy to put that code back in, but too lazy to do so right now. Patch accepted, but I doubt it's relevant.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.