Closed (fixed)
Project:
Registry Rebuild
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2011 at 20:34 UTC
Updated:
6 Jan 2012 at 01:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
neclimdulhow do install this and run it with d7 sites?
Comment #2
neclimdulSorry that was a bit terse(pre coffee) comment. What I mean is I created #1332950: Support 8.x post /core move because I wasn't looking for a port, I was looking for support. You don't install different versions of drush scripts, drush commands are expected to work in different version of Drupal because of how its used.
Also, I'm looking for something that will help me bisect across the /core move which means it sort of needs to support 2 states of drupal8 which is going to be... special...
Comment #3
rfaySorry - I must have misunderstood... I agree that the drush part will have to handle the multiple versions successfully. Not going to be able to help with the git bisect I don't think :-)
neclimdul++
Comment #4
neclimdulWould be less an issue if this existed in core and and was translated across the move... ;)
Comment #5
rfayI pretty much think this should exist in at least drush core but probably drupal core, as you say.
Comment #6
rfay@wojtha marked #1328718: D8 port as a duplicate of this one.
Comment #7
wojtha commentedI didnt noticed the issue so I created the issue #1335558: Port to Drupal 8 independently (now closed as duplicate).
Here is my patch. The only difference is that I'm trying to enable the Entity module (I migrated today from the state when the entity was part of the common shared libraries).
Comment #8
rfayProbably better to at least say "entity module was enabled if it existed" or act based on the db_update. No biggie though.
Is it always reasonable to enable entity just because it's discovered in the system table?
Comment #9
rfayI tried out #7 and was able to get out of hell on my D8 install using the php registry_rebuild.php approach, but the drush integration doesn't seem to be right yet:
Comment #10
rfay@wojtha could you explain why you need to independently enable entity module? It seems to me if it was already enabled, that's good... if not...
Comment #11
rfayHere's a version that works for me on D7 and D8.
Comment #12
rfayCommitted: http:/drupalcode.org/project/registry_rebuild.git/commitdiff/a1881e1
Certainly open to improvements.
Comment #13
rfayHad to follow up with http://drupalcode.org/project/registry_rebuild.git/commitdiff/2154391 since I broke D7 drush.
Comment #14
wojtha commented@rfay #18, I had older codebase of D8 before "corepocalypse" and when entity was a common library (entity.inc) not a module. But now entity isn't common library but a required module, needed early in the bootstrap...
So basically it fixes the transition from the state before that commit:
Comment #15
rfayOK, thanks.
Comment #16
rfaySince so much time has passed and we'd assume the older d8 code is gone, I'm moving this back to fixed. If there are any issues, I'm still happy to put that code back in, but too lazy to do so right now. Patch accepted, but I doubt it's relevant.