Play tab and hook_view fixes
vhmauery - April 2, 2007 - 00:11
| Project: | Video |
| Version: | 5.x-1.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
It has come to my attention that the play tab does not use hook_view. There is really no reason for this. In the video_view hook, it is possible to simply check the arg(2) argument to see if we should play the video. Then, all the requests get sent through hook_view, which calls the nodeapi hooks so other modules can modify the play page.
This patch removes the callback to node/nnn/play so it automatically reverts to the callback for node/nnn. Then it has video_view check to see if it should be playing the video rather than viewing the thumbnail. This is done at the same point as playinbody.
It also removes the thumbnail from the play page (which in my opinion should not be there.) But that part of the patch is really optional.
| Attachment | Size |
|---|---|
| update_play_in_body.patch | 1.72 KB |
#1
Sounds like a good thing to be able to do. +1 for flexibility in being able to customise that page.
#2
#3
Automatically closed -- issue fixed for 2 weeks with no activity.