Hi thanks for this module

I installed it this morning and it causes the checkout panes to load twice (see attachment)

it's a cool module and me thinks it could also be used as a Terms and Conditions check too

CommentFileSizeAuthor
#3 uc restrictions top pane194.52 KBstevieb
#3 uc restrictions duplicate pane216.34 KBstevieb
uc_restrictionserrors.jpg206.91 KBstevieb

Comments

bob.hinrichs’s picture

bob.hinrichs commented

Thanks so much for your help here, Steve, I definitely am not seeing this misbehavior on my installation. 1) are you 100% sure this only began when you started using this module and it is not due to something else? 2) If I cannot reproduce it (on a very basic D7+ubercart installation, no theming or additional contrib modules), then my question is naturally what is the difference between our respective systems? There is someone else who has helped me test this module and she did not report this issue. Anything unusual on your end?

stevieb’s picture

stevieb commented

hey thanks for your speedy reply

I have a pretty standard ubercart installed no excessive rules
the shop is for Germany only
the following Panes are included in the checkout

Cart contents
Calculate shipping cost
Order comments
Payment method - (only bank transfer)
Customer information
Billing information
Delivery information
terms and conditions ( this is a webform pane ( the problem persists even when this is deactivated)
Age Requirement

Hide delivery information when carts have no shippable items. (true)
Use collapsing checkout panes with Next buttons. (true) (when false the panes still duplicate)
Collapse pane after its Next button is clicked. (true)

when I use Opera dragonfly

the first form has the the following html code

<fieldset class="form-wrapper" id="cart-pane">
<legend><span class="fieldset-legend">Cart contents</span></legend>

your module repeats this underneath the normal cart pane 

<fieldset class="uc-cart-checkout-form form-wrapper" id="age_requirement-pane">
<legend><div class="fieldset-wrapper"></fieldset>
<fieldset class="uc-cart-checkout-form form-wrapper" id="age_requirement-pane">

In the morning I'll test a fresh drupal install and see if the module works on that or if the problem persists

best

stevieb’s picture

stevieb commented
StatusFileSize
new uc restrictions duplicate pane216.34 KB
new uc restrictions top pane194.52 KB

so I checked this out this morning

the age restriction works only if its on the top Pane (see attached img "uc restrictions top pane")
it duplicates every pane above it (see img uc restrictions duplicate pane)

bob.hinrichs’s picture

bob.hinrichs commented

Thanks Steve, I was able to find the problem, it was due to some changes in the pane hook plus I had named a variable 'form', which is now passed into the hook, so it was adding the existing form to the pane. I've pushed up another version and tonight the change should be incorporated into a new package.

stevieb’s picture

stevieb commented
Status: Active » Fixed

it works like a dream

I've changed the status to fixed

thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.