When settings is returned via ajax using ajax_command_settings().
The settings is not null and if it doesnt have jcarousel property, it results in js error
settings = settings || Drupal.settings;
"settings.jcarousel is undefined"

here is a patch to fix this

CommentFileSizeAuthor
#3 jcarousel_ajax_fix-1330386-2.patch478 byteschia
jcarousel_ajax_settings_fix.patch4.42 KBchia

Comments

juampynr’s picture

juampynr commented
Status: Active » Reviewed & tested by the community

Verified. Applies cleanly and fixes the issue.

Thanks.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Needs work

Could we simplify this patch (and the nested logic) just by using:

if (!settings.jcarousel) {
  return;
}

At the top of our behavior? This would help with consistency between the D6 and D7 versions. It'd also make the patch easier for me to review.

chia’s picture

chia commented
Status: Needs work » Needs review
StatusFileSize
new jcarousel_ajax_fix-1330386-2.patch478 bytes

Simplified the patch by removing nested logic.

myha’s picture

myha commented

In D6 for me working code is:

if (!settings.jcarousel || !settings.jcarousel.carousels) {
  return;
}
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks guys. I used chia's patch and amended it with myha's suggestion. Committed to 2.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.