Provide a way to repair the taxonomy_catalog field

What's the name of your taxonomy reference field? I think Ubercart expects it to be called taxonomy_catalog, which probably isn't the case if you change it from the default vocabulary.

Well, it's a bug, I guess. You should be able to change the existing Catalog taxonomy reference field to point to a different vocabulary, but that means changing your data. The catalog vocabulary selection should probably be changed to a taxonomy reference field selection to handle this.

Actually, perhaps we should depend on the taxonomy_catalog field here. Have you deleted it from your product content type already? If not, just use that and make it point to a different vocabulary in the field settings. If you have deleted it, I guess we need some way of letting you recreate it.

Awaiting answers to questions in #4

Max, I don't know if this is your problem but I just had the same with the catalog block appearing to do nothing. When I ticked the box under the title in configure block, "Make the block title a link to the top-level catalog page." the catalog came to life. When I clicked on the title I got my categories and clicking on one, the catalog displayed for that category. Sorry if this was already obvious to you. Sometimes it's the smallest things that trip us up (or they do me!)

Attached patch fixes #1074906: Warning: array_intersect(): Argument #2 is not an array in uc_catalog_uc_store_status() and adds a basic repair facility.

I think this can be extended further and the catalog vid setting dropped in favour of using the field settings, but that's for another day.

Committed, with a test to ensure it all works as expected.