I've noticed a few minor issues with the upload form for privatemsg attachments:

  • If you press Upload without selecting a new file, an empty row is added.
  • If you check Remove for a file and then upload another file, the Remove check option is cleared when the form refreshes.
CommentFileSizeAuthor
#1 privatemsg-1330788-1-attachment_fixes.patch8.42 KBarithmetric

Comments

arithmetric’s picture

arithmetric commented
Status: Active » Needs review
StatusFileSize
new privatemsg-1330788-1-attachment_fixes.patch8.42 KB

Attached is a patch that fixes these 2 bugs as well as fixes some whitespace issues.

Status: Needs review » Needs work

The last submitted patch, privatemsg-1330788-1-attachment_fixes.patch, failed testing.

arithmetric’s picture

arithmetric commented
Status: Needs work » Needs review

#1: privatemsg-1330788-1-attachment_fixes.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, commited!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.