i have some issues with an image field for a multilingual (2 languages) taxonomies.
i have images with same fid for both languages but i can't see for both terms edit forms.
it seems that the missing of the language argument for field_attach_form funcion was rhe reason
so using
field_attach_form('taxonomy_term', $term, $form, $form_state, $term->language);
instead of
field_attach_form('taxonomy_term', $term, $form, $form_state);
as it is for nodes made my day.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | field-attach-language-1330974-8.patch | 1006 bytes | oriol_e9g |
| #5 | field-attach-language-1330974-5.patch | 648 bytes | oriol_e9g |
| #2 | field-attach-language-1330974-2.d7.patch | 628 bytes | oriol_e9g |
| #2 | field-attach-language-1330974-2.patch | 628 bytes | oriol_e9g |
Comments
Comment #1
tim.plunkettThanks for the bug report. This seems like a valid change.
Please read through Status settings for an issue.
For an issue to be needs review, it must have a patch. See instructions for Making a Drupal patch with Git.
Comment #2
oriol_e9gSolve first in D8
Comment #4
tim.plunkettI knew I forgot something in my first comment.
@oriol_e9g in D8 everything is in a /core directory, it seems you left that out of the patch.
Comment #5
oriol_e9gComment #6
oriol_e9gYes I knew, this is the correct patch for D8.
Comment #8
oriol_e9gI forgot to define the default language value.
Comment #9
oriol_e9gComment #10
xjmThanks @oriol_e9g. The addition of
LANGUAGE_NONEto the default values makes sense.The next thing we need here is an an automated test that fails without the patch from #8, and passes with it. Maybe the problem description in the issue summary can be used to devise a functional test.
Comment #11
dave reidThis makes total sense, but is not at all a bug report considering taxonomy terms have no language concept in core. I just also don't want to give anyone any false ideas when looking at the code that languages are supported for terms out of the box.
Comment #12
xjmDave Reid pointed out that since core doesn't actually support multiple languages for taxonomy in D7, this isn't actually a bug. However, we should still allow contrib to add language handling, so this is still a valid patch. Recategorizing as a task.
Comment #13
xjmSo based on #11, let's additionally add some inline comments to the patch that clarify that the langcode support is provided for other modules and that core does not include language handling for taxonomy entities.
Comment #14
ZenDoodles commentedNabbed for Zgear!
Comment #15
Zgear commentedComment #16
xjmComment #17
k_zoltan commented#1499596: Introduce a basic entity form controller this issue resolved (took out) the bug from the drupal 8 core but need backport to drupal 7.
Comment #18
k_zoltan commented#1495648: Introduce entity language support this issue resolved the bug for the Drupal 7 core
Comment #19
k_zoltan commentedchecked for Drupal 8 & 7 (see above) fixedin both by other issues => marking it as fixed