Role expiration rules: tokens fail

Looking forward to any solution and thank you :)

I've run into this also. It makes uc_roles quite unusable for production sites, so I've increased the Priority of this issue.

Please post a patch if you know what the problem is ...

I know the symptom, as described by @mariagwyn but it's not clear to me what the solution is. It looks like uc_role tokens are not part of the expiration data made available to the rule "Notify customer when a role is about to expire" but I don't know enough about rules or the way it interacts with uc_roles to have a patch at this time. How does a uc_role get "in scope" for the rule?

I may have found the issue, more testing required:

diff --git a/modules/ubercart/uc_roles/uc_roles.tokens.inc b/modules/ubercart/uc_roles/uc_roles.tokens.inc
index 0c06404..19f5284 100644
--- a/modules/ubercart/uc_roles/uc_roles.tokens.inc
+++ b/modules/ubercart/uc_roles/uc_roles.tokens.inc
@@ -43,8 +43,8 @@ function uc_roles_tokens($type, $tokens, $data = array(), $options = array()) {
 
   $replacements = array();
 
-  if ($type == 'uc_role' && !empty($data['uc_role'])) {
-    $object = $data['uc_role'];
+  if ($type == 'uc_role' && !empty($data['uc_roles'])) {
+    $object = $data['uc_roles'];
 
     foreach ($tokens as $name => $original) {
       switch ($name) {

The above alteration fixes the issue for me.

@jonathan_hunt: Thank you for finding that. OK, so the problem seems to be a typo. But I believe the proper key is 'uc_role' so I think this should be fixed in the calling function, not in uc_roles.tokens.inc, otherwise it will cause other problems elsewhere.

Please undo your changes and try this patch to see if it also fixes the problem:

That's working for me, thanks.

Committed #7.