Correct handling of Query strings and fragments(anchors)

I think this should fix it, can someone else check this out?

Looks good, thanks!

BTW I changed it to use drupal_http_build_query.

This has been committed and included in the new v7.x-2.3 release.

This is not quite right, if you are using drupal_goto(), you cannot pass a query string or fragment (anchor) directly in the path, drupal_goto will try to encode ?, =, and # which will break urls with them in it. You have to pass those elements as an array as the second parameter, right now you are passing an empty array. I've also updated the link_field case to try to match an internal system path to its alias if it is one. See below:

  // Work out the destination path to redirect to. Each field type is handled
  // slightly differently, so identify that here.
  $path = '';
  $options = array();
  if (!empty($field['type'])) {
    switch ($field['type']) {
      // Link field.
      case 'link_field':
        if (!empty($item['url'])) {
          $alias = drupal_get_path_alias($item['url']);
          $options = array('query' => $item['query'], 'fragment' => $item['fragment']);
          if ($alias != $item['url']) {
            $path = $alias;
          } else {
            $path = $item['url'];
          }
        }
        break;

Correct the message display, pass $options as the second parameter to url():

      $message = t('This page is set to redirect to <a href="!path">another URL</a>, but you have permission to see the page and not be automatically redirected.', array('!path' => url($path, $options)));

Pass $options as the second parameter in drupal_goto():

      drupal_goto($path, $options, $response_code);

Probably not the most elegant solution to this, especially when it comes to determining if a path is an internal system path with an alias, but it gets the job done in my limited testing.

@dwatson: Thanks for identifying that fragments were also being truncated (I'd have preferred a new issue but it's not a big deal). I'm going to go with what I've attached.

Committed.