Menu and breadcrumb customising

Many thanks to the hand-holding from jastraat and Caroline. I thought I'd post the full results, in case helpful for others.

Having said that, I'm not entirely happy with my ugly preg_replace method for stripping the links out of active local tabs - I'd much prefer it if there was a way to simply find out if that link item was an active local tab and not produce the links in the first place... so if anyone's got any ideas here, I'd be right grateful :)

Anyway, here goes:

/***
  * Overrides HTML output for primary and secondary links:
  *  - no link tag is provided on the menu item for the current page
  *  - class="active" is preserved for menu items in the current path
  *  - strong tags are added to the current page menu item, to emphasise it as such.
  */

function phptemplate_menu_links($links) {
  $this_page = menu_get_active_title();
  $is_current = FALSE;
  $is_active = FALSE;
  if (!count($links)) {
    return '';
  }
  $level_tmp = explode('-', key($links));
  $level = $level_tmp[0];
  $output = "<ul class=\"links-$level\">\n";
  foreach ($links as $index => $link) {
    $output .= '<li';
    if ($link['title'] == $this_page) {
      $is_current = TRUE;
    }
    if (stristr($index, 'active')) {
      $is_active = TRUE;
    }
    if ($is_active) {
      $output .= ' class="active"';
    }
    if ($is_current || drupal_is_front_page() && $link['title'] == "Home") {
      $output .= "><strong>". $link['title'] ."</strong></li>\n";
    }
    else {
      $output .= ">". l($link['title'], $link['href'], $link['attributes'], $link['query'], $link['fragment']) ."</li>\n";
    }
    $is_current = FALSE;
    $is_active = FALSE;
  }
  $output .= '</ul>';
  return $output;
}


/***
  * Overrides the HTML output for all links in block menus:
  *  - no link tag is provided on the menu item for the current page
  *  - strong tags are added to the current page menu item, to emphasise it as such.
  */

function phptemplate_menu_item_link($item, $link_item) {
  $this_page = menu_get_active_title();
  if ($item['title'] == $this_page || drupal_is_front_page() && $item['title'] == "Home" || $active) {
    return "<strong>". $item['title'] ."</strong></li>\n";
  }
  else {
    return l($item['title'], $link_item['path'], !empty($item['description']) ? array('title' => $item['description']) : array(), isset($item['query']) ? $item['query'] : NULL);
  }
}


/***
  * Overrides the HTML output for links in "local task" menus:
  *  - link tag is stripped out of active local tab.
  *  - strong tags added to active local tab to emphasise this as the current action. 
  */

function phptemplate_menu_local_task($mid, $active, $primary) {
  if ($active) {
    // regular expression to strip out html tags from the menu item link
    $active_link = preg_replace ("/(<\/?)(\w+)([^>]*>)/e", "", menu_item_link($mid));
    return '<li class="active"><strong>'. $active_link ."</strong></li>\n";
  }
  else {
    return '<li>'. menu_item_link($mid) ."</li>\n";
  }
}


/***
  * Overrides the default breadcrumbs HTML, to make it a "you are here" inidcator:
  *  - "Home" is added if we're on the homepage
  *  - The current page is added at the end, although not hyperlinked. 
  */

function phptemplate_breadcrumb($breadcrumb) {
  if (drupal_is_front_page()) {
    return 'Home';
  }
  if (!empty($breadcrumb)) {
    //Append title of current page
    $breadcrumb[] = drupal_get_title();
    return ''. implode(' > ', $breadcrumb);
  }
}

Any suggestions for improvements welcome.

Mark
flet.org

I discovered a tricky problem with the above theme functions which led to block menus not working properly. However, I found a fix - so both the problem and the solution are addressed here:
http://drupal.org/node/171529

I think these functions are approaching stability now, so when I get around to it I'll try and add a book page somewhere about this. It's also feeding into an high-accessibility theme I'm working on, which I imagine will be available for Drupal 5 shortly after Drupal 6 is released :/ *sigh* :D

Mark
flet.org

I have to say, that after a few months of using these template snippets, I'm not sure I'd recommend the non-hyperlinking of "active" menu items.

My method strips link tags based on matching the link text with the current page title, and also if the link contains an "active" class. This has caused me a number of problems though, including:

• If two menu links have the same name but point to different places, they'll both be inactive.
• Page "tabs" in tracker and views can be messed up, with more than link being stripped, making some pages inaccessible.

All in all, I'm going to keep working on this, but I don't think it's production ready yet.

Mark
flet.org