Comments

erikwebb’s picture

Status: Active » Postponed

It doesn't look like there's any other place for XHProf documentation at the moment. Both the Github and PECL pages point to this nonexistent documentation.

gribnif’s picture

Looks like either of these two would work:

http://pecl.php.net/package/xhprof
http://php.net/xhprof

erikwebb’s picture

Status: Postponed » Needs review

The second link qualifies more as documentation.

msonnabaum’s picture

The php.net docs point to web archive, which is pretty embarrassing. I've submitted a bug report to facebook, hopefully they will fix.

panshulk’s picture

Issue summary: View changes

The link is still broken, I think we can update the documentation with this like that is suggested in #2 .
Also we can point to the drupal documentation here : https://www.drupal.org/docs/develop/development-tools/xhprof-code-profiler.

andypost’s picture

Where the link should be updated?

panshulk’s picture

StatusFileSize
new68.73 KB

Hey @andypost
This is about updating the link on the module description page.
The link : " http://mirror.facebook.net/facebook/xhprof/doc.htm "
is broken here : link

andypost’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev

Thank you @panshulk, fixed with suggestion #5 because other links already in "D8" section (which soon should become 9.0)

Also would be great to fix https://git.drupalcode.org/project/xhprof/-/blob/8.x-1.x/README.md in separate issue

panshulk’s picture

Thanks @andypost
This looks good now.

Also, created a separate issue to update README.md here : https://www.drupal.org/project/xhprof/issues/3130177

Also, can we move this issue to "Fixed", since there are no more changes required for this issue.

Thanks.

andypost’s picture

Status: Needs review » Fixed
Related issues: +#3130177: README.md file needs to be updated with more information

Thanks to all, added credits to everyone

andypost’s picture

Konstantin Komelin’s picture

Created the issue 8 years ago. Wow.
Thanks to everyone involved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.