When has no tabs on the page then an empty <div> goes to output. Like this: <div class="tabs clearfix"></div>
Because the $tabs variable in the region--content.tpl.php file is an array. Like this: 

Array
(
    [#theme] => menu_local_tasks
    [#primary] => 
    [#secondary] => 
)

This check is not enough: if ($tabs) :
This is better: if ($tabs && !empty($tabs['#primary']) :

CommentFileSizeAuthor
#7 tab_condition_omega-7x-4x_1332732-7.patch599 byteschris burge
#3 tab_condition_1332732-4.patch845 byteshydra

Comments

hmmdinger’s picture

hmmdinger commented

Agreed. I just spent a good bit of time debugging some extra space in IE7 that ended up being because of this empty $tabs div.

othermachines’s picture

othermachines commented

Marked #1385770: Tabs Wrapper printed even if tabs is empty as duplicate of this issue.

hydra’s picture

hydra commented
Status: Active » Needs review
StatusFileSize
new tab_condition_1332732-4.patch845 bytes

Had this issue also some times...

cellar door’s picture

cellar door commented
Assigned: Unassigned » himerus

ah IE7 how we love you so... :)

himerus’s picture

himerus commented
Assigned: himerus » Unassigned
Status: Needs review » Fixed

Comitted to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chris burge’s picture

chris burge commented
Version: 7.x-3.x-dev » 7.x-4.x-dev
Issue summary: View changes
Status: Closed (fixed) » Active
StatusFileSize
new tab_condition_omega-7x-4x_1332732-7.patch599 bytes

Re-opening this issue as there is a regression in 7.x-4.x. The line is question is as follows in 7.x-4.x:

<?php print render($tabs); ?>

This results in the re-introduction of the bug fixed by this issue in 7.x-3.x. This issue proposes fixing the regression by changing the line as follows:

<?php print ($tabs && !empty($tabs['#primary']) ? render($tabs) : '' ); ?>

Patch is attached.

chris burge’s picture

chris burge commented

I haven't tested either 7.x-5.x, and 8.x-5.x, but neither of these versions check !empty($tabs['#primary']. It is probable that this bug exists in both versions, too. I'll defer to someone more active with the project on those versions.

chris burge’s picture

chris burge commented
Status: Active » Needs review
tedfordgif’s picture

tedfordgif commented
Related issues: +#997408: $tabs is always set, +#953034: [meta] Themes improperly check renderable arrays when determining visibility

This could be seen as a dupe of the core bug #997408: $tabs is always set, which is closed-as-duplicate in favor of the more general bug #953034: [meta] Themes improperly check renderable arrays when determining visibility.