Don't have a lot of time. Here is a quick patch for 5.x-1.x. I had some weird spacing in Panels where everything was double-spaced, so this patch may be bunk. Let me know.

CommentFileSizeAuthor
#6 panels_css_5.1.x.patch16.62 KBrecidive
#4 panels_2.patch7.64 KBxen
#2 panels.css_.2.x.patch24.39 KBRobRoy
#1 panels.css__0.patch24.45 KBRobRoy
panels.css_.patch24.45 KBRobRoy

Comments

RobRoy’s picture

RobRoy commented
StatusFileSize
new panels.css__0.patch24.45 KB

Fixed one div thing, for 5.x-1.x still.

RobRoy’s picture

RobRoy commented
StatusFileSize
new panels.css_.2.x.patch24.39 KB

Sorry, these are pretty sloppy. I had some IE7 fixes in some of them, but might need another IE7 passthrough. That's what the 47% stuff is for in twocol_stacked. Hopefully someone else can do that, if not I'll gve it another go when time permits.

Here is a 5.x-2.x slopfest.

merlinofchaos’s picture

merlinofchaos commented

Hmm. For some reason, this patch fails to apply, though I can't figure out why. I'm wondering if it's cr/lf translation going on somewhere that's throwing off diff, because the patch doesn't look quite properly formed.

xen’s picture

xen commented
StatusFileSize
new panels_2.patch7.64 KB

Try this one instead, looking through RobRoys patch, I seem to be doing the same thing. Hopefully I've made the patch properly.

The problem is in the CSS selectors:

.panel-2col-stacked div div {
  margin: .5px;
}

which matches not only the div containing the panel, but all nested divs. Using the child selector '>', fixes the issue in Firefox and other browsers, but IE6 doesn't understand it. Adding a class for the panel content div and selecting on that instead, works for all browsers.

Patch against 5.x-1.2.

recidive’s picture

recidive commented

It seems the problem with RobRoy's patches is that almost every single line of layouts code has a trailing space and his patches get rid of them.

Xen.dk's patch uses another approach. I think RobRoy's one is better.

A big +1 to this, I had to hack panels module on my projects to get rid of those margins.

recidive’s picture

recidive commented
StatusFileSize
new panels_css_5.1.x.patch16.62 KB

I was partially wrong about the trailing spaces stuff, it applies only to css files.

It seems panels .inc files has Windows line endings. I've rerolled the patch so you can clearly see the changes on those files.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Closed (won't fix)

This has all changed anyway, so won't fixing.