Needs work
Project:
Drupal Commons
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Nov 2011 at 23:04 UTC
Updated:
1 Mar 2015 at 09:19 UTC
Jump to comment: Most recent
Because Commons has a rather high number of modules, it would benefit from the module_implements cache backport for D6:
http://drupal.org/node/557542#comment-5104544
Here's a before/after for this patch on the stream page:

As you can see, this eliminates over 6800 calls to module_hook shaving over 100ms off the request.
| Comment | File | Size | Author |
|---|---|---|---|
| commons_module_implements_cache.png | 85.21 KB | msonnabaum |
Comments
Comment #1
ezra-g commented100ms per request - Awesome!
This is committed -- Thanks @msonnabaum!
http://drupalcode.org/project/commons.git/commitdiff/9f74e92?hp=40a13e81...
Comment #2
ezra-g commentedI reverted this patch because it was causing an error when installing Commons -- The install appeared to work fine but after clicking the "View your new site" (or similar) link, I got a 500 error at /stream, with "PHP Fatal error: Unsupported operand types in includes/common.inc on line 1592" in the PHP error log. After a drush cc all, the /stream page is a 404 but the site seems otherwise functional.
"
I had this behavior with both the 175 and 178 version of the patch.
Comment #3
lsolesen commented