Because Commons has a rather high number of modules, it would benefit from the module_implements cache backport for D6:

http://drupal.org/node/557542#comment-5104544

Here's a before/after for this patch on the stream page:

As you can see, this eliminates over 6800 calls to module_hook shaving over 100ms off the request.

CommentFileSizeAuthor
commons_module_implements_cache.png85.21 KBmsonnabaum

Comments

ezra-g’s picture

Status: Needs review » Fixed

100ms per request - Awesome!

This is committed -- Thanks @msonnabaum!

http://drupalcode.org/project/commons.git/commitdiff/9f74e92?hp=40a13e81...

ezra-g’s picture

Status: Fixed » Needs work

I reverted this patch because it was causing an error when installing Commons -- The install appeared to work fine but after clicking the "View your new site" (or similar) link, I got a 500 error at /stream, with "PHP Fatal error: Unsupported operand types in includes/common.inc on line 1592" in the PHP error log. After a drush cc all, the /stream page is a 404 but the site seems otherwise functional.
"

I had this behavior with both the 175 and 178 version of the patch.

lsolesen’s picture

Version: » 6.x-2.x-dev
Issue summary: View changes