I'm trying to change the value of resource without success(in admin/config/nodejs/js). Whatever you fill in the form value, it's always returning '/socket.io'.

Looking in the nodejs.module:

function nodejs_get_config() {
  $defaults = array(
    'scheme' => variable_get('nodejs_server_scheme', 'http'),
    'secure' => variable_get('nodejs_server_scheme', 'http') == 'https' ? 1 : 0,
    'host' => variable_get('nodejs_config_host', 'localhost'),
    'port' => variable_get('nodejs_config_port', '8080'),
    'resource' => '/socket.io',
    'authToken' => md5(session_id()),
    'serviceKey' => variable_get('nodejs_config_serviceKey', ''),
  );

  return variable_get('nodejs_config', array()) + $defaults;
}

It should get the value from the database instead of provide a simple string.

CommentFileSizeAuthor
#1 nodejs-socketio-resource-1334176-1.patch586 bytescarnau

Comments

carnau’s picture

Status: Active » Needs review
StatusFileSize
new586 bytes

Patch provided.

Anonymous’s picture

yep, looks good, will review and commit soon.

Anonymous’s picture

Status: Needs review » Active

committed and pushed to 7.x-1.x:

http://drupalcode.org/project/nodejs.git/commit/71d7d6d

thanks!

moving to 6.x-1.x for julien to look at.

julien’s picture

Thank you, commited to 6.x-1.x-dev.

Anonymous’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 71d7d6d on 7.x-1.x, auth-refactor, 8.x-1.x, 8.x-1.x-head authored by carnau, committed by beejeebus:
    #1334176: Socket.io resource option is always equal to '/socket.io',...