Hi

I just installed 5.x-1.x-dev, but don't see any reduction in SQL queries etc. It appears that a new instance of Memcache is being created for every cache query, possibly because of the following code in memcache.inc :

      // Link all the servers to this cluster.
      foreach ($memcache_servers as $s => $c) {
        if ($c == $cluster) {

The problem is that $memcache_servers appears to contain arrays, rather than something that can be compared to $cluster.

$memcache_servers = Array
(
    [default] => Array
        (
            [localhost] => Array
                (
                    [0] => 11211
                )
        )
)

This same missmatch happens again a few lines later, preventing the update which would referencfe the new Memcache.

Of course, it's more likely to be user error on my part! In that case, I apologise in advance.

Thanks!

CommentFileSizeAuthor
#1 memcache.inc_.patch1.82 KBlyricnz

Comments

lyricnz’s picture

lyricnz commented
StatusFileSize
new memcache.inc_.patch1.82 KB

Patch to fix iteration of $memcache_servers. Also disables "Merge overrides from memcache.module".

robertdouglass’s picture

robertdouglass commented

Sorry, this is a documentation error. I'm changing the way the configuration arrays are structured, so if you tried this with the old arrays it would bomb.

Try with arrays like this (or no configuration arrays whatsoever if you want to just run localhost:11211):

$conf = array(
  'cache_inc' => './includes/memcache.inc',
  'memcache_servers' => array('localhost:11211' => 'default', '127.0.0.1:11212' => 'default', 'localhost:11213' => 'content', '127.0.0.1:11214' => 'config'),
  'memcache_bins' => array('cache' => 'default', 'cache_page' => 'content', 'cache_node' => 'content', 'cache_filter' => 'config'),
);

The structure of memcache_servers is host:port => cluster. The structure of memcache_bins is bin => cluster. Certain defaults are assumed: Cluster: 'default', bin 'cache'. You should always have an entry for them in both the memcache_servers and memcache_bins arrays.

lyricnz’s picture

lyricnz commented

Please update README.txt - it's the only information endusers have about how to configure their memcache. Is a configuration page likely at some stage?

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

I'm working on one right now.

lyricnz’s picture

lyricnz commented
Status: Active » Closed (fixed)

Please update README.txt - it's the only information endusers have about how to configure their memcache. Is a configuration page likely at some stage?

lyricnz’s picture

lyricnz commented
Status: Closed (fixed) » Fixed

Please update README.txt - it's the only information endusers have about how to configure their memcache. Is a configuration page likely at some stage?

Update: README.txt has been significantly updated

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

Config page is very likely very soon.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)