the last comma in param list makes a syntax error 

Drupal
.
formatPlural
(
1,
"Whitespace Call plural",
"Whitespace Call @count plural",
)
;

should be

"Whitespace Call @count plural"
CommentFileSizeAuthor
#8 1334768-8.patch361 bytesfietserwin
#2 trailing_comma-1334768-2.patch341 bytessawtell

Comments

aspilicious’s picture

aspilicious commented
Issue tags: +Novice

Yes it's true and it will fail on some browsers.
Can you make a patch?

sawtell’s picture

sawtell commented
StatusFileSize
new trailing_comma-1334768-2.patch341 bytes

My first patch, hope it does the job!

aspilicious’s picture

aspilicious commented
Status: Active » Needs review

You have to set it to needs review to trigger the testbot.
Let's see if your patch gets accepted.

Thnx for making it!

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Reviewed & tested by the community

thanks

sawtell’s picture

sawtell commented

Ah yes, I missed that step. D'oh!

NP, hopefully the first of many ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

D'oh! Thanks a lot for the fix!

Committed and pushed to 7.x. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Version: 7.x-dev » 8.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new 1334768-8.patch361 bytes

Error also appears in 8.x

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Reviewed & tested by the community

Thi shas already been reviewed for D7, it is an extrmeley small and simnple change, no other changes in D8 are touching this (except the move to /core), so I guess this can be set to RTBC without additional reviews?!

aspilicious’s picture

aspilicious commented

true :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Hmm not sure why this never got committed to 8.x in the first place, but committed/pushed to 8.x now.

Automatically closed -- issue fixed for 2 weeks with no activity.