The fact that the UI calls these fields a "field-collection" is very odd. I see no reason to not use proper English. Non-english translators should, rightly, not translate "field-collection" since it appears to be a machine name of some kind. But they really, really should provide a translation, which is why the entity's name should not have a dash: "field collection".

CommentFileSizeAuthor
#6 1335082-fix-permission-name.patch570 bytesdave reid
#2 1335082-2-no-dash.patch33.95 KBjohnalbin
#1 field-collection-no-dash.patch33.92 KBjohnalbin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Needs review
StatusFileSize
new field-collection-no-dash.patch33.92 KB

Here's a patch.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
StatusFileSize
new 1335082-2-no-dash.patch33.95 KB

Re-rolled patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

http://drupalcode.org/project/field_collection.git/commit/e8cf2fe
Awesome, thanks for caring about things like this :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Major
Status: Closed (fixed) » Needs work

This made one change that actually needs to be rolled back or supported in update.php: it changed the machine name of the permission. So now all the sites that had the 'administer field-collections' assigned to roles are now broken because the permission is now 'administer field collections'. A simple update hook should suffice here.


@@ -493,9 +493,9 @@ function field_collection_admin_paths() {
  */
 function field_collection_permission() {
   return array(
-    'administer field-collections' =>  array(
-      'title' => t('Administer field-collections'),
-      'description' => t('Create and delete fields on field-collections.'),
+    'administer field collections' =>  array(
+      'title' => t('Administer field collections'),
+      'description' => t('Create and delete fields on field collections.'),
     ),
   );
 }
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 1335082-fix-permission-name.patch570 bytes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Committed, thanks for catching that!
http://drupalcode.org/project/field_collection.git/commit/a4dfe55

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.