Attached patch extends the mergevars token support to allow more tokens, i.e. it adds in nested tokens of the next level.

Unrelated to that, it might make things simpler if the own "mergevars" api would be dropped in favor of just using tokens. That should suffice.

Even more unrelated, there are lots of whitespace problems in the code. Be sure to do not use tabs for indentation (see coding standards).

CommentFileSizeAuthor
mailchimp_tokens.patch1.23 KBfago

Comments

levelos’s picture

levelos commented
Status: Needs review » Fixed

Thanks @fago, fixed in 04ae3843c8ce29d27259d9a9c824e1dc8c5d847c.

White space hiccups are taken care of as well.

Re: replacing the mergevars API with just tokens, happy to include that. Lets create as a standalone feature request and we'll put it in the queue.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Fixed » Needs work

I noted you left a dpm() statement in the committed code:

-    return $tokens;
+  dpm($tokens);
+  return $tokens;
fago’s picture

fago
Primary language German
Location Vienna
commented

sry, triple post

fago’s picture

fago
Primary language German
Location Vienna
commented

sry, triple post

levelos’s picture

levelos commented
Status: Needs work » Closed (fixed)

Already removed in subsequent commits.