I've run into this issue with inline module before, although I don't know how I fixed it then. It bit me again now with the 5.x-1.0 release.

Specifically, if an image is supposed to display inline I get nothing. Actually, I get an empty link element. I tracked the problem down to theme_inline_img(), which calls theme_image(). The path it passes is the result of file_create_url, which is the full file URL including http://. theme_image(), in turn, sees it can't open that file and so returns nothing unless you have iowrappers enabled for fopen(), which many servers do not. (It's off by default.) Ick.

This patch simply sets the flag to theme_image() to not bother trying to determine a size of the image. That skips the offending parts of theme_image() and allows images to display properly.

CommentFileSizeAuthor
#1 inline_4.patch1.62 KBsun
image_getsize.patch731 bytesCrell

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Crell » sun
StatusFileSize
new inline_4.patch1.62 KB

theme_inline_img() became defective in the last commit for imagecache support. file_create_url() is absolutely unnecessary here, since Inline does not (yet) support remote files.

Attached patch removes those function calls.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to HEAD and 5.x.

Crell’s picture

Crell commented

Works great, thanks. Will there be a formal 1.1 release?

slombardi’s picture

slombardi commented

Hi, I tryed to patch my inline module using the inline_4.patch but I get the following:

Parse error, unexpected ')' in ../modules/inline/inline.module on line 261

i tried to have a look at the code but find no way to correct that syntax..

thanks in advance

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@deng: This patch is already committed. You might want to update your Inline module to the latest release 1.1.

slombardi’s picture

slombardi commented

HI,
sorry I didn't realiza that.
I'm using the 1.1.2.1 version of the module, but I still get a problem displaying images inline either with or without imagecache activated.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@deng: Please download the latest release of Inline and replace the module in your Drupal installation with these files. If you still encounter problems then, file a new issue please.

slombardi’s picture

slombardi commented

hi sun...still having the problem. I'll open a new issue as you said.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)