A few UI tweaks

Here's another patch (to replace the first one) that takes things a big step further. I hope you don't mind my dipping right in, but I've got a client who is pretty excited about testing out this module provided there are a few usability improvements. The rest of it works great, which is a relief since it would probably make my brain explode.

What the patch does:

- Changes the user route to the upload form. This is a major change. I've removed the "Upload nodes" link on the content overview page and instead provided direct links to the upload form on the field widgets in the node/add form. The upload form itself is now a local task beneath node/add/%. Short of embedding the upload in the form, this is (I think) where the user would expect to find it. It also puts the upload form into visual context with the node/add form (as a local task), and it gets rid of that extra click. With this change, the 'upload_nodes' page becomes unnecessary so I've removed that, as well.

- Changes final redirect. Priority on final redirect is based on user's original location. A 'redirect' variable in the URL query string keeps track of this (I originally used 'destination' but it caused a conflict somewhere). Defaults to the 'node/add' form. If this for some reason fails (URLs can be manipulated), user is redirected to the content overview page, if permitted; otherwise, to the homepage. NOTE: the 'redirect' variable is simply to add some flexibility for users who may not take the traditional route to the node/add form; e.g. a group member creating group content.

- Changes permissions on config items. Requires permission 'administer site configuration' for all module configuration tasks, including cleanup (previously set to 'access content').

- Integration with OG create permissions module (a selfish move-- I need this :)).

- Adds message to inform the user when moving from upload to edit form: 'Files uploaded successfully! You may now edit each node.'

- Removes upload_nodes_admin_paths() - no longer needed.

- Some wording changes.

Looking forward to getting some feedback. Cheers -

Nitpicky reroll:

In upload_nodes_field_widget_form_alter(), look for $element[0]['#description'] instead of $element['#description'] if upload limit == 1.

In _upload_nodes_access() missing space in permission argument. (OK, that's kinda important.)

Hi, pyrollo. Thanks for the feedback. I'm testing this on a site for a conference that is set to begin tomorrow, so I definitely expect to get some user feedback during the next few days.

#1 - upload_nodes_admin_paths() sets 'upload_nodes', which no longer exists with this patch. Or do you mean you're not sure about removing the page provided at 'upload_nodes'?

Whether a "snapshot" page ('upload_nodes') is needed is up for debate. Can you think of a scenario where a user would need to see all of their enabled fields in a list rather than linking to the /upload page for a field directly? It's possible I just haven't thought of one, yet.

To be clear on how file paths have changed, here's a look at what it may have looked like before:

upload_nodes/article/field_article_image/upload

And now:

node/add/article/field_article_image/upload

To return to the page you were on after uploading:

node/add/article/field_article_image/upload?redirect=node/82

#2 - "bug in upload_nodes_field_widget_form_alter" - Hmm, I wasn't able to duplicate this. The link is built using a modified version of your function _upload_nodes_base_url() which includes the content type id in the link path. I've tested this with multiple content types with the functionality enabled. Maybe I'm misunderstanding?

Cheers-

Opening a specific issue regarding entry points is a good idea.

#2 - I think I get you. Sounds like you're looking at where the loop breaks on a match of field_name, here:

foreach (_upload_nodes_get_managed_targets() as $target) {
  if ($target['field_name'] == $context['field']['field_name']) {
    ...
    break;
  }
}

Is that right?

I'm curious about how you were able to create two fields with the same name. I didn't think this was allowed?

Anyway, wouldn't hurt to check on node type, too. Attaching another patch.

Thanks -

HI, pyrollo. Happy to hear my suggestions have been committed! I've downloaded the latest -dev and can confirm that everything works well.

FYI - I've been using the module in production since last October with no problem reports. The site is http://c4d.undg.org

Regarding redirecting to the homepage - this is tricky because you don't know if the user is uploading from the back-end admin or the public site. Ordinarily I wouldn't recommend unexpectedly redirecting the user from admin/ into the public site (or vice-versa), but that wouldn't necessarily be the case. Redirecting to the node/add form just seemed the simplest solution since that is where they started, and it seems to be a common approach. For instance, when you edit content from the Content overview page, after you are finished you are always redirected back to Content overview.

Thanks again for the great work.