Since entity makes revisions trivial, we need to use the functionality. Beans are content and content should have revisions.

CommentFileSizeAuthor
#17 bean_revisions.patch28.86 KBindytechcook
#14 bean_revisons.patch28.42 KBindytechcook
#13 bean_revisons.patch38.06 KBindytechcook
#12 bean_revisions.patch28.34 KBindytechcook
#11 bean_revisions.patch23.62 KBindytechcook
#9 bean_reisions.patch23.41 KBindytechcook
#5 bean_revisions.patch19.88 KBindytechcook
#4 bean_revisions.patch19.89 KBindytechcook

Comments

indytechcook’s picture

indytechcook commented
Issue tags: +Release blocker

Tagging with release blocker

indytechcook’s picture

indytechcook commented

This is dependent on #996696.

alexweber’s picture

alexweber commented

For the sake of clarity: #996696: Support revisions in Entity API

indytechcook’s picture

indytechcook commented
Status: Active » Needs review
StatusFileSize
new bean_revisions.patch19.89 KB

Work is occurring in the bean_revisions branch. Here is the first pass at a patch (totally untested). This requires the patch from the entity API module

indytechcook’s picture

indytechcook commented
StatusFileSize
new bean_revisions.patch19.88 KB

Ignore previous patch. I did the diff backwards. Here is the correct one.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work 
+++ b/bean.install
@@ -176,3 +299,21 @@ function bean_update_7006() {
+function bean_update_7007(&$return) {
+  $schema = bean_schema();
+  $bean = $schema['bean'];
+  $bean_revision = $schema['bean_revision'];
+
+  db_drop_primary_key('bean');
+  db_change_field('bean', 'bid', 'bean', $bean['bid'], array('primary key' => array('bid')));
+  db_add_field('bean', 'vid', $bean['vid']);
+  db_add_unique_key('bean', 'vid', array('vid'));
+
+  db_create_table('bean_revision', $bean_revision);

After the bean_revision table is created, don't you need to prepopulate it with a first round of revisions (where revision id = bean id)? When I created a patch for Field Collection awhile ago to support revisions, I did this. I had assumed it was necessary.

Also, you have a lot of logic for handling the revisions but I thought that the Entity API patch gives you a lot of it for "free"... I didn't try understanding what you were doing, though, so maybe it is all necessary.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs work » Needs review

Putting back to needs review for others to review.

indytechcook’s picture

indytechcook commented
Status: Needs review » Needs work

Thanks. I've made a bunch of changes since last night. I'll push up a new patch today.

indytechcook’s picture

indytechcook commented
StatusFileSize
new bean_reisions.patch23.41 KB

Here is another patch. I'm still working off of the bean_revisions branch in git.

Left to do:

  • Update hook to fill data
  • Test, test, test.
indytechcook’s picture

indytechcook commented

@Kristen The entity api module handles the saving and loading mostly. You still have to tell it when to save a new revision and which one to load. Some of the code is just overriding the load method with a one line change.

indytechcook’s picture

indytechcook commented
Status: Needs work » Needs review
StatusFileSize
new bean_revisions.patch23.62 KB

Updated Patch. Work is also in the bean_revisions patch.

indytechcook’s picture

indytechcook commented
StatusFileSize
new bean_revisions.patch28.34 KB

Updated patch to add the ability to set the active revision. the bean_revisions branch is still up to date

indytechcook’s picture

indytechcook commented
StatusFileSize
new bean_revisons.patch38.06 KB

Updated patch to match the new entity api patch #996696: Support revisions in Entity API

indytechcook’s picture

indytechcook commented
StatusFileSize
new bean_revisons.patch28.42 KB

Merged in code before rolling patch this time

indytechcook’s picture

indytechcook commented
Status: Needs review » Needs work

Patch needs to be rerolled against current entity API patch.

indytechcook’s picture

indytechcook commented

The patch has been committed to entity api. No more moving target! #996696: Support revisions in Entity API

indytechcook’s picture

indytechcook commented
Status: Needs work » Needs review
StatusFileSize
new bean_revisions.patch28.86 KB

UPdated patch

indytechcook’s picture

indytechcook commented
Status: Needs review » Fixed

This has been committed. Please open new issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

muschpusch’s picture

muschpusch commented

this is giving me trouble: #1864564: duplicate entry 0 for VID in {bean}

muschpusch’s picture

muschpusch commented
Issue summary: View changes

Updated issue summary.