OpenData is a data visualizer/publisher created by BLENCorp for the Department of Education and is currently used to build Data.ED.gov. It enables administrators to quickly publish data on a Drupal site.

Sandbox: http://drupal.org/sandbox/blencorp/1271078
git clone --branch master blencorp@git.drupal.org:sandbox/blencorp/1271078.git
The project is made for Drupal 6

Thanks

Comments

doitDave’s picture

doitDave commented
Status: Needs review » Needs work

Hi,

on a quick sight I only found this: opendata .module, l21-29 (please remove unneeded code instead of commenting it out).

The a question: You are using document.getElementsByClassName JS syntax in opendata.js. Are you aware that jQuery ships with Drupal so you could use a more cross-browser-compliant code here (which is considered an important Drupal property)?

mikeendale’s picture

mikeendale commented
Status: Needs work » Needs review

Hello--

The code is now updated. Can you please review?

Thanks,

Mike

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

The automated review found lots of formatting errors: http://ventral.org/pareview/httpgitdrupalorgsandboxblencorp1271078git

If you have problems fixing them or you think there is a false positive, please ask!

patrickd’s picture

patrickd commented
Status: Needs work » Needs review

Switched back to needs review, so in-depth reviews won't be blocked by coding standart issues.

mikeendale’s picture

mikeendale commented

Updated all formatting issues, deleted all files from master and moved it to 6.22-1.0-dev brach

Here is the result: http://ventral.org/pareview/httpgitdrupalorgsandboxblencorp1271078git-62...

Thanks for all the help getting this validated, Patrick

patrickd’s picture

patrickd commented

You can use branches however you like but if you want that drupal.org realize them as 'releases' you have to be shure that they are well formatted

eg:
Branch: 6.x-1.x, 6.x-2.x, ..
Tags: 6.x-1.0, 6.x-1.0-alpha1, 6.x-1.0-beta2, ..
See http://drupal.org/node/1015226 for more information about this

mikeendale’s picture

mikeendale commented

Hi Patrick-

Thanks for the heads up. We've created a new branch, 6.x-1.x and pushed it. We've also deleted the old branch.

Can you please review it?

Thanks,

Mike

mikeendale’s picture

mikeendale commented

We made a few bug fixes that was causing problem running the module.

mikeendale’s picture

mikeendale commented

Hello Patrick,

Curious if you've found problem with approving this module. Is there anything we can do to get it through?

Thanks,

Mike

patrickd’s picture

patrickd commented

Sorry for the delay! Too many applications and too little reviewers with too few time to review :/

The biggest problem I see on your application is that the module you want to get reviewed is quite complex, it will take more time and more reviews than most of the other applications. (what does not mean the module is bad!)

If you want to get this done more quickly I'd suggest you to apply a less complex module. On the other hand this module is very interesting and it would be great to have a deeper look on it!

mikeendale’s picture

mikeendale commented

Hi Patrick--

I completely understand.

For the module, if you, or anyone from the review team is available for 10 mins, I can demo it for you over skype. It is a fairly important module for us to publish as it is because we believe there is a strong case to be made about using this module to make the 'Data.gov-in-a-box' vision come true. Here are the details from The White House blog: http://www.whitehouse.gov/blog/2011/12/05/datagov-goes-global

Please let me know if you're available for a quick demo.

Thanks,

Mike

misc’s picture

misc commented

I think this like a really important project, and I am planning on doing a review on Friday, if nobody else get there first, is it possible for you to get on-line on skype on Friday?

misc’s picture

misc commented

Still want to do a a review of this, do you have the time to do a demo over Skype soon?

c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Status: Needs review » Needs work

Hello blencorp,
I have installed this modules successfully with all dependencies in a fresh drupal 6.25 system. I have only activated "google charts" for this test.
I tried to find out what this module does and how it is working about 15 minutes.
I think there is kind of documentation issue and this is not solved by a demonstration via skype.
So please do a little bit more description of what the module is doing and how to use.

http://ventral.org/pareview/httpgitdrupalorgsandboxblencorp1271078git
Pareview is reporting a lot of errors. Maybe some new reports of the tool. But the coding standard are errors are old e.g. the control structures:
http://drupal.org/node/318#controlstruct

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Updated the description to give more information