Respond.js module needs to integrate with Libraries API

CommentFileSizeAuthor
#3 respondlibraries-1335834-3.patch6.44 KBanthonyR
#2 respondlibraries-1335834-2.patch6.5 KBanthonyR

Comments

anthonyR’s picture

anthonyR commented
Version: » 7.x-1.x-dev

I'm doing the first steps for this, just have a small issue, will contact you on IRC and can post a patch later on.

anthonyR’s picture

anthonyR commented
StatusFileSize
new respondlibraries-1335834-2.patch6.5 KB

Here's a basic patch for libraries support. Also updated the readme on installing the library.

anthonyR’s picture

anthonyR commented
StatusFileSize
new respondlibraries-1335834-3.patch6.44 KB

Fix my error in the previous version

anthonyR’s picture

anthonyR commented
Status: Active » Needs review
rupl’s picture

rupl
he/him
Primary language English
commented
Title: Libraries integration » Libraries API - basic support
Status: Needs review » Fixed

Hey this is a great patch, thanks! I took the code and committed it to dev along with some other changes. I want to keep the naming convention consistent, so I changed the variables and directories to 'respondjs'

I also removed the hard dependency on Libraries API. Although we should support it, I don't want to require the dependency, especially since respond.js is GPLv2 and we can ship the module with the library included. The module will favor the Libraries API when it is enabled, but will fall back to the module's copy if something goes wrong.

Changing the scope slightly and setting this to fixed for now. If other bugs pop up just open new issues using the Libraries component.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.