Do a Barrel Roll!

Hi barraponto,

coder results look good, there is one really small issue:

• Although this is a very tiny module, you should take a look at http://drupal.org/node/1354 and add the file and function comments as described there.

Two personal notes aside:

1. As I am not a really experienced reviewer yet, I can only suspect that this module might probably not pass the review process as I noticed that a certain module complexity is regarded as a "proof" of your Drupal experience's extent. Just to mention.
2. Drupal strongly focuses on standards and compatibility. Although I myself am desperately waiting for CSS3 finally becoming an approved standard, it unfortunately isn't yet. Thus, your additions break compliance with any advanced markup check and also probably lead to strange results even in still up-to-date browsers. (But, as I said, a rather personal opinion; I am aware that many community members already focus on HTML5 which is far from release status as well.)

Good luck!

Hi, looks fixed for me. Let's wait for more comments.

As for CSS3, this was really but a personal opinion aside reviewing. Decisions like this are of course up to a site admin and, even more, his intended audience ;)

Anyhow, keep in mind that "does not work on IE" is really not the only implication that may come up until the offiicial W3C release of CSS3.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/doabarrelroll.module:
   +4: [minor] There should be no trailing spaces
  
  Status Messages:
   Coder found 1 projects, 1 files, 1 minor warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

Amusing as this is, is there any reason why you didn't throw one of your more worthwhile modules into the submission queue? There's not enough in this module to actually get a feel for your coding, project handling, git use or understanding of Drupal APIs and security issues.

For a reviewer to actually get an idea of those properties, they are going to have to go off to the other works you have and go from there.

A least I had some fun making google spin the page. Any change of a D6 port :P

I agree with ELC - can't we review a bigger project of yours? Please close this issue if you agree and open a new one for that other project. Other input is welcome as well of course.

Though this is a rather small module, it's also very clean ... and barraponto's post/commit history speaks for itself - clean projects, proper use of javascript behaviours and other APIs, a custom theme, node form columns co-maintainer, and some cutting edge SASS stuff in the sandbox.

I also would have preferred to have seen a larger project submitted (such as the Compass plugin) ... but after attempting to actually look through the Compass sandbox, I realized that it probably would get caught up in this process for weeks as we waited for a front-end reviewer who is familiar with the techniques.

Based on this conclusion, the application code, community activity and post/commit history; combined with what I saw in barraponto's other sandbox projects, I wouldn't have any issues with marking this one as RTBC.

Although this module on its own is a little small to approve you, I agree with jthorson that your other work is enough.

Thanks for your contribution, barraponto! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.