Needs review
Project:
Splash
Version:
6.x-2.6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Nov 2011 at 11:32 UTC
Updated:
22 Aug 2012 at 18:22 UTC
Jump to comment: Most recent file
Hello,
First of all, i think this is a great module.
I only have one problem with it.
When I type the URL directly in the browser, the spash screen shows.
When I google my site and click on it it doesn't show.
Could anyone tell me, what i can do to make sure the google traffic also see my splash screen?
Thanks,
Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | splash-referer-check-to-general-1336394-5280150.patch | 690 bytes | colin49 |
Comments
Comment #1
tomrishworth commentedI'm experiencing the same problem. Its weird because the site preview that google shows is the splash page, but when you click through the splash page doesn't show.
Comment #2
tanthoni commentedSame problem.
Comment #3
colin49 commentedI ran into this issue as well and determined the problem. The Splash module has a check to see if the referer url matches the sites base url and when this is true it assumes the user is coming from an internal url and it doesn't show the splash page. While this is the desired behaviour the logic checks to see if the base url is contained in any part of the referer url which is what causes the problem. Urls coming from Google include the destination site url as a query paramater in the referer url and this triggers the internal condition.
Example of the referer url value when you click on a Google link going to http://www.yoursite.com
Eg: http://www.google.com/url?sa=t&rct=j&q=YourSite&source=web&cd=2&ved=0CDU...
I've included a patch which modifies the referer url check to only consider referer urls which start with the sites base url as internal urls.
Cheers,
Colin
Comment #4
colin49 commentedComment #5
colin49 commentedBump! :)