Hello,
These small bugs perhaps exist also in majority of branchs (6.x-4.x, 6.x-2.x).
All changes are in the patch file of comment #1.
hotel_booking/hotel_booking.install
9 schema warnings
all wanings are setting a string to the default value of int.
Line 226, 247, 254, 261, 268, 275, 283, 290, 297
hotel_booking/hotel_booking.theme.inc
2 value name errors (Bugs in "admin/store/hotel_booking/occupancy_modifiers")$modifier->hoidshould be
$modifier->hbomidLine 176, 177
hotel_booking/hotel_booking.admin.inc
drupal_goto('admin/store/hotel_booking/rates/'. $form_state['values']['hbrid'] .'/delete');This code (Line 623) doesn't work at all, we can delete it (commented in patch file).
Instead, we want to add a line in hotel_booking_rates_form_validate() before Line 702 to redirect the page.$form_state['rebuild'] = TRUe;This isn't a real problem, just spell. (Line 649)
'admin/store/hotel_booking/rate_modifiers/'. $$modifier->hbrmid,duplicate $ (Line 779)
===============Then, some redirect bugs in submit functions
function hotel_booking_rates_delete_form_submit($form, $form_state) {should be
function hotel_booking_rates_delete_form_submit($form, &$form_state) {Line 817
Also in line 834 function hotel_booking_rate_modifiers_delete_form_submit(), 848 function hotel_booking_occupancy_modifiers_delete_form_submit().return 'admin/store/hotel_booking/rate_modifiers';should be
$form_state['redirect'] = 'admin/store/hotel_booking/rate_modifiers';Line 842
Also in line 856 function hotel_booking_occupancy_modifiers_delete_form_submit()
I will upload the patch file after create this issue, because I can't name the patch without issue-number.
Perhaps I have forgotten the others that I have corrected. I wish there's nothing forgotten.
In the end of this comment, thanks for the great module!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | uc_hotel_bugsfix-1336482-2.patch | 6.85 KB | dawnlight |
Comments
Comment #1
dawnlight commentedThe problem in theme.inc has been fixed in dev.
======
Here is the patch generated by git
I'm not sure that I have the right to commit the files in uc_hotel.git
I have only an access of drupal git with 'dawnlight' as username and my email.
PS:
Sorry, I have confused the number-comment for the filename of patch.
Comment #1.0
dawnlight commentedDuplicate the code, add comment of patch